qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix ATAPI GET_CONFIGURATION function
Date: Sat, 24 May 2008 21:54:54 +0200	[thread overview]
Message-ID: <AE7A8D4B-809E-497B-BC28-F786F7181502@suse.de> (raw)
In-Reply-To: <51775D7B-EA5B-471C-A664-ADA734850CB6@suse.de>

Please ignore this patch. It is valid for KVM only.

On May 24, 2008, at 12:31 PM, Alexander Graf wrote:

> Is there anything particularly wrong with this patch? Does it break  
> any guest OSs I am not aware of?
> If not, please include it as it's a pretty obvious bug.
>
> Alex
>
> On May 21, 2008, at 4:34 PM, Alexander Graf wrote:
>
>> The current implementation of GET_CONFIGURATION in the ATAPI stack  
>> of qemu replies a different length depending on the buffer, the  
>> data should be written into.
>>
>> On the other hand the SCSI spec defines that length information has  
>> to be consistent and independent of return buffer lengths.
>>
>> This patch makes the ATAPI emulation behave according to the spec  
>> and fixes the Darwin DVD driver.
>>
>> Signed-off-by: Alexander Graf <agraf@suse.de>
>> Signed-off-by: Kevin Wolf <kwolf@suse.de>
>>
>>

  reply	other threads:[~2008-05-24 19:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 14:34 [Qemu-devel] [PATCH] Fix ATAPI GET_CONFIGURATION function Alexander Graf
2008-05-24 10:31 ` Alexander Graf
2008-05-24 19:54   ` Alexander Graf [this message]
2008-05-25  7:53   ` Carlo Marcelo Arenas Belon
2008-05-25  9:27     ` Alexander Graf
2008-05-25 10:38       ` Carlo Marcelo Arenas Belon
2008-05-26  8:59         ` Alexander Graf
2008-05-26 17:46         ` Alexander Graf
2008-05-27 18:10           ` Carlo Marcelo Arenas Belon
2008-05-30  1:32             ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AE7A8D4B-809E-497B-BC28-F786F7181502@suse.de \
    --to=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).