qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: "Cédric Le Goater" <clg@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH] tests/functional: Require 'user' netdev for ppc64 e500 test
Date: Sun, 09 Mar 2025 09:49:00 +0000	[thread overview]
Message-ID: <B2FAB7F7-B42F-45C8-8ED5-72BB2F89EDAF@gmail.com> (raw)
In-Reply-To: <20250308071328.193694-1-clg@redhat.com>



Am 8. März 2025 07:13:28 UTC schrieb "Cédric Le Goater" <clg@redhat.com>:
>When commit 72cdd672e18c extended the ppc64 e500 test to add network
>support, it forgot to require the 'user' netdev backend. Fix that.
>
>Fixes: 72cdd672e18c ("tests/functional: Replace the ppc64 e500 advent calendar test")
>Signed-off-by: Cédric Le Goater <clg@redhat.com>
>---
> tests/functional/test_ppc64_e500.py | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tests/functional/test_ppc64_e500.py b/tests/functional/test_ppc64_e500.py
>index 9ce7ae6c4798..f5fcad9f6b66 100755
>--- a/tests/functional/test_ppc64_e500.py
>+++ b/tests/functional/test_ppc64_e500.py
>@@ -20,6 +20,7 @@ class E500Test(LinuxKernelTest):
> 
>     def test_ppc64_e500_buildroot(self):
>         self.set_machine('ppce500')
>+        self.require_netdev('user')
>         self.cpu = 'e5500'
> 
>         uimage_path = self.ASSET_BR2_E5500_UIMAGE.fetch()

Thanks for taking care of it, Cédric.

Acked-by: Bernhard Beschow <shentey@gmail.com>


  parent reply	other threads:[~2025-03-09  9:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-08  7:13 [PATCH] tests/functional: Require 'user' netdev for ppc64 e500 test Cédric Le Goater
2025-03-08  7:26 ` Philippe Mathieu-Daudé
2025-03-09  9:49 ` Bernhard Beschow [this message]
2025-03-10 10:04 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B2FAB7F7-B42F-45C8-8ED5-72BB2F89EDAF@gmail.com \
    --to=shentey@gmail.com \
    --cc=clg@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).