[PATCH v2 0/1] SDL2: fix handling of the AltGr key on Windows again

[PATCH v2 0/1] SDL2: fix handling of the AltGr key on Windows again

[Volker Rümelin]

Based-on: <20230417192139.43263-1-shentey@gmail.com>
([PATCH v2 0/2] SDL2 usability fixes)

Windows sends an extra left control key up/down input event for
every right alt key up/down input event for keyboards with
international layout. Since commit 830473455f ("ui/sdl2: fix
handling of AltGr key on Windows") QEMU uses a Windows low level
keyboard hook procedure to reliably filter out the special left
control key and to grab the keyboard on Windows.

SDL2 version 2.0.16 introduced its own Windows low level keyboard
hook procedure to grab the keyboard. When enabled with a grabbed
keyboard, this disables the special left control key filter and
handling of the AltGr key on Windows is broken again.

This patch fixes handling of the AltGr key on Windows with
international keyboard layout.

v2:
Fixed the cover letter subject, so that :patchew applies this
patch series to the correct QEMU branch.

Volker Rümelin (1):
   ui/sdl2: disable SDL_HINT_GRAB_KEYBOARD on Windows

  ui/sdl2.c | 3 +++
  1 file changed, 3 insertions(+)

-- 
2.35.3

[PATCH v2 1/1] ui/sdl2: disable SDL_HINT_GRAB_KEYBOARD on Windows

[Volker Rümelin]

Windows sends an extra left control key up/down input event for
every right alt key up/down input event for keyboards with
international layout. Since commit 830473455f ("ui/sdl2: fix
handling of AltGr key on Windows") QEMU uses a Windows low level
keyboard hook procedure to reliably filter out the special left
control key and to grab the keyboard on Windows.

The SDL2 version 2.0.16 introduced its own Windows low level
keyboard hook procedure to grab the keyboard. Windows calls this
callback before the QEMU keyboard hook procedure. This disables
the special left control key filter when the keyboard is grabbed.

To fix the problem, disable the SDL2 Windows low level keyboard
hook procedure.

Reported-by: Bernhard Beschow <shentey@gmail.com>
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
 ui/sdl2.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ui/sdl2.c b/ui/sdl2.c
index 00aadfae37..9d703200bf 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -855,7 +855,10 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
 #ifdef SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR /* only available since SDL 2.0.8 */
     SDL_SetHint(SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR, "0");
 #endif
+#ifndef CONFIG_WIN32
+    /* QEMU uses its own low level keyboard hook procecure on Windows */
     SDL_SetHint(SDL_HINT_GRAB_KEYBOARD, "1");
+#endif
 #ifdef SDL_HINT_ALLOW_ALT_TAB_WHILE_GRABBED
     SDL_SetHint(SDL_HINT_ALLOW_ALT_TAB_WHILE_GRABBED, "0");
 #endif
-- 
2.35.3

Re: [PATCH v2 1/1] ui/sdl2: disable SDL_HINT_GRAB_KEYBOARD on Windows

[Bernhard Beschow]

Am 18. April 2023 06:56:52 UTC schrieb "Volker Rümelin" <vr_qemu@t-online.de>:
>Windows sends an extra left control key up/down input event for
>every right alt key up/down input event for keyboards with
>international layout. Since commit 830473455f ("ui/sdl2: fix
>handling of AltGr key on Windows") QEMU uses a Windows low level
>keyboard hook procedure to reliably filter out the special left
>control key and to grab the keyboard on Windows.
>
>The SDL2 version 2.0.16 introduced its own Windows low level
>keyboard hook procedure to grab the keyboard. Windows calls this
>callback before the QEMU keyboard hook procedure. This disables
>the special left control key filter when the keyboard is grabbed.
>
>To fix the problem, disable the SDL2 Windows low level keyboard
>hook procedure.
>
>Reported-by: Bernhard Beschow <shentey@gmail.com>
>Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>

FWIW:

Tested-by: Bernhard Beschow <shentey@gmail.com>

>---
> ui/sdl2.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/ui/sdl2.c b/ui/sdl2.c
>index 00aadfae37..9d703200bf 100644
>--- a/ui/sdl2.c
>+++ b/ui/sdl2.c
>@@ -855,7 +855,10 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
> #ifdef SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR /* only available since SDL 2.0.8 */
>     SDL_SetHint(SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR, "0");
> #endif
>+#ifndef CONFIG_WIN32
>+    /* QEMU uses its own low level keyboard hook procecure on Windows */
>     SDL_SetHint(SDL_HINT_GRAB_KEYBOARD, "1");
>+#endif
> #ifdef SDL_HINT_ALLOW_ALT_TAB_WHILE_GRABBED
>     SDL_SetHint(SDL_HINT_ALLOW_ALT_TAB_WHILE_GRABBED, "0");
> #endif

Re: [PATCH v2 1/1] ui/sdl2: disable SDL_HINT_GRAB_KEYBOARD on Windows

[Stefan Weil via]

Am 18.04.23 um 08:56 schrieb Volker Rümelin:

> Windows sends an extra left control key up/down input event for
> every right alt key up/down input event for keyboards with
> international layout. Since commit 830473455f ("ui/sdl2: fix
> handling of AltGr key on Windows") QEMU uses a Windows low level
> keyboard hook procedure to reliably filter out the special left
> control key and to grab the keyboard on Windows.
>
> The SDL2 version 2.0.16 introduced its own Windows low level
> keyboard hook procedure to grab the keyboard. Windows calls this
> callback before the QEMU keyboard hook procedure. This disables
> the special left control key filter when the keyboard is grabbed.
>
> To fix the problem, disable the SDL2 Windows low level keyboard
> hook procedure.
>
> Reported-by: Bernhard Beschow <shentey@gmail.com>
> Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
> ---
>   ui/sdl2.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/ui/sdl2.c b/ui/sdl2.c
> index 00aadfae37..9d703200bf 100644
> --- a/ui/sdl2.c
> +++ b/ui/sdl2.c
> @@ -855,7 +855,10 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
>   #ifdef SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR /* only available since SDL 2.0.8 */
>       SDL_SetHint(SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR, "0");
>   #endif
> +#ifndef CONFIG_WIN32
> +    /* QEMU uses its own low level keyboard hook procecure on Windows */


s/procecure/procedure/


>       SDL_SetHint(SDL_HINT_GRAB_KEYBOARD, "1");
> +#endif
>   #ifdef SDL_HINT_ALLOW_ALT_TAB_WHILE_GRABBED
>       SDL_SetHint(SDL_HINT_ALLOW_ALT_TAB_WHILE_GRABBED, "0");
>   #endif


The typo fix for the comment does not require a v3 and can be applied in 
the pull request.

Reviewed-by: Stefan Weil <sw@weilnetz.de>

Re: [PATCH v2 1/1] ui/sdl2: disable SDL_HINT_GRAB_KEYBOARD on Windows

[Bernhard Beschow]

Am 24. April 2023 03:33:05 UTC schrieb Stefan Weil <sw@weilnetz.de>:
>Am 18.04.23 um 08:56 schrieb Volker Rümelin:
>
>> Windows sends an extra left control key up/down input event for
>> every right alt key up/down input event for keyboards with
>> international layout. Since commit 830473455f ("ui/sdl2: fix
>> handling of AltGr key on Windows") QEMU uses a Windows low level
>> keyboard hook procedure to reliably filter out the special left
>> control key and to grab the keyboard on Windows.
>> 
>> The SDL2 version 2.0.16 introduced its own Windows low level
>> keyboard hook procedure to grab the keyboard. Windows calls this
>> callback before the QEMU keyboard hook procedure. This disables
>> the special left control key filter when the keyboard is grabbed.
>> 
>> To fix the problem, disable the SDL2 Windows low level keyboard
>> hook procedure.
>> 
>> Reported-by: Bernhard Beschow <shentey@gmail.com>
>> Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
>> ---
>>   ui/sdl2.c | 3 +++
>>   1 file changed, 3 insertions(+)
>> 
>> diff --git a/ui/sdl2.c b/ui/sdl2.c
>> index 00aadfae37..9d703200bf 100644
>> --- a/ui/sdl2.c
>> +++ b/ui/sdl2.c
>> @@ -855,7 +855,10 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
>>   #ifdef SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR /* only available since SDL 2.0.8 */
>>       SDL_SetHint(SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR, "0");
>>   #endif
>> +#ifndef CONFIG_WIN32
>> +    /* QEMU uses its own low level keyboard hook procecure on Windows */
>
>
>s/procecure/procedure/
>
>
>>       SDL_SetHint(SDL_HINT_GRAB_KEYBOARD, "1");
>> +#endif
>>   #ifdef SDL_HINT_ALLOW_ALT_TAB_WHILE_GRABBED
>>       SDL_SetHint(SDL_HINT_ALLOW_ALT_TAB_WHILE_GRABBED, "0");
>>   #endif
>
>
>The typo fix for the comment does not require a v3 and can be applied in the pull request.
>
>Reviewed-by: Stefan Weil <sw@weilnetz.de>

Ping