From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47904 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnfmH-0000Fa-SK
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 18:46:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <agraf@suse.de>) id 1OnfmG-0005IZ-KL
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 18:46:05 -0400
Received: from cantor.suse.de ([195.135.220.2]:57210 helo=mx1.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <agraf@suse.de>) id 1OnfmG-0005IN-Cz
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 18:46:04 -0400
Subject: Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging
Mime-Version: 1.0 (Apple Message framework v1081)
Content-Type: text/plain; charset=us-ascii
From: Alexander Graf <agraf@suse.de>
In-Reply-To: <F481E293-2570-47BF-8575-9D78E83EA573@suse.de>
Date: Tue, 24 Aug 2010 00:45:59 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <B5AAA57B-BD29-4F78-AE4C-4D63B41B539C@suse.de>
References: <1282600951-30803-1-git-send-email-agraf@suse.de>
	<1282600951-30803-5-git-send-email-agraf@suse.de>
	<4C72F46D.5040606@codemonkey.ws>
	<F481E293-2570-47BF-8575-9D78E83EA573@suse.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel List <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>


On 24.08.2010, at 00:23, Alexander Graf wrote:

>=20
> On 24.08.2010, at 00:21, Anthony Liguori wrote:
>=20
>> On 08/23/2010 05:02 PM, Alexander Graf wrote:
>>> The monitor command for hotplugging is in i386 specific code. This =
is just
>>> plain wrong, as S390 just learned how to do hotplugging too and =
needs to
>>> get drives for that.
>>>=20
>>> So let's add a generic copy to generic code that handles drive_add =
in a
>>> way that doesn't have pci dependencies.
>>>=20
>>> I'm not fully happy with the patch as is. IMHO there should only be =
a
>>> single target agnostic drive_hot_add function available. How we =
could
>>> potentially fit IF_SCSI in there I don't know though.
>>>=20
>>> Signed-off-by: Alexander Graf<agraf@suse.de>
>>>=20
>>=20
>> I think you really want device_add plus a blockdev_add.
>=20
> Device_add already works with this set and only required minor changes =
the s390 specific code. So that part was pretty slick :). The part that =
didn't work was the drive_add one.
>=20
> What is blockdev_add supposed to be? drive_add without IF_SCSI?

To be a bit more precise on how things work with this set:

(qemu) drive_add 0 id=3Dmy_disk,if=3Dnone,file=3D/dev/null
OK
(qemu) device_add virtio-blk-s390,drive=3Dmy_disk,id=3Dnew_disk

gives me a working new virtio disk in the VM that's mapped to /dev/null =
:).


Alex=