From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56062 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PUZSi-0006Z6-7X
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 01:43:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1PUZSf-00041W-OD
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 01:43:12 -0500
Received: from fmmailgate03.web.de ([217.72.192.234]:54380)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1PUZSf-00041L-Ga
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 01:43:09 -0500
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
In-Reply-To: <1292775761-6061-4-git-send-email-andreas.faerber@web.de>
Subject: Re: [Qemu-devel] [PATCH v4 3/3] target-i386: Fix accidental use of
	SoftFloat uint64 type
References: <1292775761-6061-1-git-send-email-andreas.faerber@web.de>
	<1292775761-6061-2-git-send-email-andreas.faerber@web.de>
	<1292775761-6061-3-git-send-email-andreas.faerber@web.de>
	<1292775761-6061-4-git-send-email-andreas.faerber@web.de>
Message-Id: <B849927A-4FFF-492A-9C9F-B42F36147AF2@web.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Apple Message framework v936)
Date: Mon, 20 Dec 2010 07:42:19 +0100
Sender: andreas.faerber@web.de
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel Developers <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>

Am 19.12.2010 um 17:22 schrieb Andreas F=E4rber:

> softfloat.h's uint64 type has least-width semantics.
> Use uint64_t instead since that is used in helpers.
>
> v4:
> * Summary change.
>
> v3:
> * Split off.
>
> Cc: Huang Ying <ying.huang@intel.com>
> Signed-off-by: Andreas F=E4rber <andreas.faerber@web.de>
> Acked-by: Juan Quintela <quintela@redhat.com>

Updated on branch with Cc -> Acked-by.

> ---
> target-i386/cpu.h |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> index 06e40f3..f0c07cd 100644
> --- a/target-i386/cpu.h
> +++ b/target-i386/cpu.h
> @@ -737,10 +737,10 @@ typedef struct CPUX86State {
>       user */
>    struct DeviceState *apic_state;
>
> -    uint64 mcg_cap;
> -    uint64 mcg_status;
> -    uint64 mcg_ctl;
> -    uint64 mce_banks[MCE_BANKS_DEF*4];
> +    uint64_t mcg_cap;
> +    uint64_t mcg_status;
> +    uint64_t mcg_ctl;
> +    uint64_t mce_banks[MCE_BANKS_DEF*4];
>
>    uint64_t tsc_aux;
>
> --=20
> 1.7.3.4
>
>