From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D517C02183 for ; Thu, 16 Jan 2025 23:40:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tYZSK-0003pn-Lf; Thu, 16 Jan 2025 18:39:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tYZSE-0003pJ-DY; Thu, 16 Jan 2025 18:39:14 -0500 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tYZS9-0001EH-FP; Thu, 16 Jan 2025 18:39:11 -0500 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5da12190e75so3040630a12.1; Thu, 16 Jan 2025 15:39:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737070745; x=1737675545; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WPddaBlTnCpqPRcq2UIs71qmpQumLiZWMEWObSxaXvU=; b=e3hK4O86cJ85Kzlw0Qp6DBdc3L+ayaOe5hjQWJ71TcRAmhJpZ7JW/vRSUNjKSNt2cu mK7YbojmpxtKy6MMu1cRIl+j4s4rzqkBhz0zxouyZrosLXGbFNQ9kjM0093Wj+Xa/dSo WtahcB+zoLJ+5hfxYeAJMQkeOJPOP6j7dvd9rMVTQGskkqvJeH82S4DItjtLhaMhtLh2 sZdriaEpq+3fhURvWv9diQ2V8Beciu1lOz6XxsZfiXaDIt8IupGXbgWq4FSb+6503khK z29ZNUQ2el9uV7tAsZ+0h4n8fdhnZzlWWd5BeRaBrQd6QhvSf7c4KKTDI+TUso64Qv86 WvkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737070745; x=1737675545; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WPddaBlTnCpqPRcq2UIs71qmpQumLiZWMEWObSxaXvU=; b=bSbw5Zup+IelMJIuHGcyyJxHtZnLGR88qH+/beXyRMiUio9WjyiNxDkahx0chVsgMy Mttequthfqs6PGtyxqRVGxKH+4gnOZaiblQj9G9gCTyYGKieM99dri2oQIMfxWNhpINv 64McDtobDNkOX6acTwLrG7vpMWorcMG6R2YLKACLVYGV353yxq96tZKnjrnbA2eA0QIA rnkV7J/IM1WdvU0PySq16JqK5QZ+ijKvGUeTY1GFswrLrJQooH/sdR7/6y1b9TLAIYTY zfuAsfHNudaUCh0VmsYn4UpaX0tK8yuKHgoSpUevkWSkBJGjOSlsgIBfij8ICVQ4E1uu loyw== X-Forwarded-Encrypted: i=1; AJvYcCVRYkZpWe/bBrvTHGIj5K6oRXBhMTWObyg+vTGcZBQMYZLW7CZvg8btvTdQAQqK8gOvtazLLBOzOejKWeI=@nongnu.org, AJvYcCXDML7jsshst8ujSvnssBbAYOqTegqzzq6O8GuAz4QVdJWYYKwxOVP3kA/ppy5w8uVLnZA7efk16a9GoQ==@nongnu.org, AJvYcCXmSmjqrxdjxEaU7u0CIAmhZH0cuWXx3hWdp3jd2rE3xcUyk7a0cLWFPmLW3DGBPRLcvCZ/SchS2Q==@nongnu.org, AJvYcCXxANmk+wDuHgyW5igsQNOEWO2TW87JyQrU69tzH6CsXbZeQ8o4PFUoVl5jJjyrWJ3zwvqLVMPHvMIkQg==@nongnu.org X-Gm-Message-State: AOJu0Ywrk/5OkOaVA7dTCHShEVtmXN1DhMPsoxaZC5+UBo8DJowMqhPv ReaKxQBk86WcgOxKpdZrypZBAbc2U9rG9tPta8BMT9FlXqorEHpA X-Gm-Gg: ASbGncs0i7tXDC8xr+KgVkf0G6jV+qIxaMF5an8k+Vrrhce8EaFGUTtRO2Qsi+oYWgj QgLkdQfc2l8bGTvKxjxloEzp/ZrNmGeSGL+vBvVp74Q0PoLkAz+gMXacDLRNBr+/krnfKgzsNYD Wx4681T3Lnbmb85ThWoSP2MohFlKBtLI3MW2P3TlqY/tZe4PgqbaEA/MuVpeT8tsy7tmwKjhoaG zGLWnMfEDCe13neZ9gm8QqYaOvg9uid5a/SvlffrZ0Ac20/Qn6dH/8SMmUVbtHPM8oDeICi6Ll9 pOWcDbxVzM3Ev32Nc+7V+hXGACg= X-Google-Smtp-Source: AGHT+IEmfM7Tp+ek7u2FHhgHhnq/qefDrmHfQuOTevufLnnN6fe1IFFGGd35rVAguqezhwCL77rT9g== X-Received: by 2002:a17:907:9805:b0:aab:c6a5:7c71 with SMTP id a640c23a62f3a-ab38b232faamr42776466b.14.1737070744747; Thu, 16 Jan 2025 15:39:04 -0800 (PST) Received: from [127.0.0.1] (dynamic-078-055-006-027.78.55.pool.telefonica.de. [78.55.6.27]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab384ce0c99sm68816166b.41.2025.01.16.15.39.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jan 2025 15:39:04 -0800 (PST) Date: Thu, 16 Jan 2025 23:39:03 +0000 From: Bernhard Beschow To: Michael Tokarev , qemu-devel@nongnu.org CC: Fabiano Rosas , Paolo Bonzini , Guenter Roeck , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , Peter Maydell , Andrey Smirnov , qemu-arm@nongnu.org, =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= , Jean-Christophe Dubois , Laurent Vivier , Bin Meng , qemu-block@nongnu.org, qemu-stable Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_01/13=5D_hw/sd/sdhci=3A_S?= =?US-ASCII?Q?et_SDHC=5FNIS=5FDMA_bit_when_appropriate?= In-Reply-To: <823b6f0c-7e2f-4cc2-bf5f-79f34c77d7f6@tls.msk.ru> References: <20250111183711.2338-1-shentey@gmail.com> <20250111183711.2338-2-shentey@gmail.com> <823b6f0c-7e2f-4cc2-bf5f-79f34c77d7f6@tls.msk.ru> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=shentey@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 15=2E Januar 2025 12:55:29 UTC schrieb Michael Tokarev : >11=2E01=2E2025 21:36, Bernhard Beschow wrote: >> In U-Boot, the fsl_esdhc[_imx] driver waits for both "transmit complete= d" and >> "DMA" bits in esdhc_send_cmd_common() by means of DATA_COMPLETE constan= t=2E QEMU >> currently misses to set the DMA bit which causes the driver to loop for= ever=2E Fix >> that by setting the DMA bit if enabled when doing DMA block transfers= =2E >>=20 >> Reviewed-by: Philippe Mathieu-Daud=C3=A9 >> Signed-off-by: Bernhard Beschow > >Is this a qemu-stable material? Good question=2E Given that this part of the code has some further issues = [1] I'd rather not alter stable behavior because we might just trade one bu= g for another=2E Best regards, Bernhard [1] > >Thanks, > >/mjt