qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure
Date: Fri, 27 May 2011 11:00:28 +0200	[thread overview]
Message-ID: <BANLkTi=1Ro1fOCAVS3M-BKZnYSDu-CSAjg@mail.gmail.com> (raw)
In-Reply-To: <BANLkTim7utDK7kQn-zKUGyF8QTMMF4Sqog@mail.gmail.com>

Any chance to get this reviewed/applied any time soon ? It currently
does not build without it with gcc 4.6.0

On 29 April 2011 17:59, Marc-Antoine Perennou <Marc-Antoine@perennou.com> wrote:
> pulse/simple.h does not include stdlib.h
> We cannot use NULL since it may not be defined
> Use 0 instead
>
> Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
> ---
>  configure |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index ea8b676..d67c3ce 100755
> --- a/configure
> +++ b/configure
> @@ -1567,7 +1567,7 @@ for drv in $audio_drv_list; do
>
>     pa)
>     audio_drv_probe $drv pulse/simple.h "-lpulse-simple -lpulse" \
> -        "pa_simple *s = NULL; pa_simple_free(s); return 0;"
> +        "pa_simple *s = 0; pa_simple_free(s); return 0;"
>     libs_softmmu="-lpulse -lpulse-simple $libs_softmmu"
>     audio_pt_int="yes"
>     ;;
> --
> 1.7.5.52.ge839f.dirty
>

  reply	other threads:[~2011-05-27  9:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-29 15:59 [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure Marc-Antoine Perennou
2011-05-27  9:00 ` Marc-Antoine Perennou [this message]
2011-06-03 20:33 ` Aurelien Jarno
2011-06-03 21:57   ` malc
2011-06-03 22:17     ` Aurelien Jarno
2011-06-03 22:54       ` malc
2011-06-09 15:52         ` Marc-Antoine Perennou
2011-06-09 17:44           ` Andreas Färber
2011-06-09 19:07             ` Peter Maydell
2011-06-10  7:14               ` Markus Armbruster
2011-06-24 13:31                 ` Marc-Antoine Perennou
2011-06-24 16:52                   ` Stefan Hajnoczi
2011-06-09 18:25   ` Markus Armbruster
2011-06-24 14:49 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=1Ro1fOCAVS3M-BKZnYSDu-CSAjg@mail.gmail.com' \
    --to=marc-antoine@perennou.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).