From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34917)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QElsz-0007an-G8
	for qemu-devel@nongnu.org; Tue, 26 Apr 2011 13:17:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QElsx-0002o3-4X
	for qemu-devel@nongnu.org; Tue, 26 Apr 2011 13:17:17 -0400
Received: from mail-vw0-f45.google.com ([209.85.212.45]:54721)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QElsw-0002nu-Sq
	for qemu-devel@nongnu.org; Tue, 26 Apr 2011 13:17:15 -0400
Received: by vws17 with SMTP id 17so705491vws.4
	for <qemu-devel@nongnu.org>; Tue, 26 Apr 2011 10:17:14 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <18082259.13471303694638277.JavaMail.weblogic@epv6ml05>
References: <18082259.13471303694638277.JavaMail.weblogic@epv6ml05>
Date: Tue, 26 Apr 2011 18:17:14 +0100
Message-ID: <BANLkTi=2PFyhd-nnMg6xaE15iNOY6BeU1w@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] target-arm: fix LDMIA bug on page boundary
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: yuyeon.oh@samsung.com
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 25 April 2011 02:23, YuYeon Oh <yuyeon.oh@samsung.com> wrote:
> target-arm: fix LDMIA bug on page boundary

(You don't need to repeat the Subject summary line in the body, it makes the
git changelog look a bit odd when the patch is applied with 'git am').

> When consecutive memory locations are on page boundary, a base register may be
> loaded before page fault occurs. After page fault handling, it losts the memory
> location information. To solve this problem, loading a base register has to put back.
>
> Signed-off-by: Yuyeon Oh <yuyeon.oh@samsung.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

I've tested this and confirmed that it fixes this bug for the
Thumb T2 encoding. However, the same problem still exists for the
T1 (16 bit) encoding; I'll send a patch for that in a moment.
(The ARM encoding did not have this bug.)

-- PMM