From: Alexandre Raymond <cerbere@gmail.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"andreas.faerber@web.de" <andreas.faerber@web.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"agraf@suse.de" <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] Fix signal handling of SIG_IPI when io-thread is enabled
Date: Wed, 15 Jun 2011 10:11:30 -0400 [thread overview]
Message-ID: <BANLkTi=6qOutuUry5y0KTjdfst8X0qbjCQ@mail.gmail.com> (raw)
In-Reply-To: <4DF86174.7090406@siemens.com>
Hi Jan,
> Why? Ahh, because of qemu_cpu_kick_self: raise(SIG_IPI)! That should
> generate a per-process SIG_IPI. And that may not only affect Darwin.
> Looks good.
Actually, with io-thread enabled, it goes through qemu_cpu_kick_self()
-> qemu_cpu_kick_thread() -> pthread_kill(..., SIG_IPI).
I think the problem is with sigwait(). It doesn't state so in the
Linux or Darwin man pages, but on Solaris, it says : "All signals
identified by the set argument must be blocked on all threads,
including the calling thread; otherwise, sigwait() might not work
correctly", which might correspond to the issue I've been witnessing
(ie: sigwait() unblocking once in a while on a SIGUSR1 (SIG_IPI) in
the event thread).
In any case, I don't think it should attempt to catch this signal at
all since the cpu thread is already catching it.
Alexandre
next prev parent reply other threads:[~2011-06-15 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 5:20 [Qemu-devel] [PATCH] Fix signal handling of SIG_IPI when io-thread is enabled Alexandre Raymond
2011-06-15 7:38 ` Jan Kiszka
2011-06-15 14:11 ` Alexandre Raymond [this message]
2011-07-09 2:33 ` Alexandre Raymond
2011-07-16 19:44 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=6qOutuUry5y0KTjdfst8X0qbjCQ@mail.gmail.com' \
--to=cerbere@gmail.com \
--cc=agraf@suse.de \
--cc=andreas.faerber@web.de \
--cc=jan.kiszka@siemens.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).