qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Raymond <cerbere@gmail.com>
To: Alexander Graf <agraf@suse.de>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Andreas Färber" <andreas.faerber@web.de>,
	"qemu-devel Developers" <qemu-devel@nongnu.org>,
	"Jan Kiszka" <jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH] sigfd: use pthread_sigmask
Date: Wed, 8 Jun 2011 19:19:33 -0400	[thread overview]
Message-ID: <BANLkTi=JBvG4Om2JmQG-UPj4ub1_6xsLAA@mail.gmail.com> (raw)
In-Reply-To: <1307573737-33421-1-git-send-email-agraf@suse.de>

On Wed, Jun 8, 2011 at 6:55 PM, Alexander Graf <agraf@suse.de> wrote:
> Qemu uses signalfd to figure out, if a signal occured without the need
> to actually receive the signal. Instead, it can read from the fd to receive
> its news.
>
> Now, we obviously don't always have signalfd around. Especially not on
> non-Linux systems. So what we do there is that we create a new thread,
> block that thread on all signals and simply call sigwait to wait for a
> signal we're interested in to occur.
>
> This all sounds great, but what we're really doing is:
>
>    sigset_t all;
>
>    sigfillset(&all);
>    sigprocmask(SIG_BLOCK, &all, NULL);
>
> which - on Darwin - blocks all signals on the current _process_, not only
> on the current thread. To block signals on the thread, we can use
> pthread_sigmask().
>
> This patch does that, assuming that my above analysis is correct, and thus
> renders Qemu useable on Darwin again.
I confirm that Qemu works much better on Darwin with this patch :)

Thanks!
Alexandre

  reply	other threads:[~2011-06-08 23:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 22:55 [Qemu-devel] [PATCH] sigfd: use pthread_sigmask Alexander Graf
2011-06-08 23:19 ` Alexandre Raymond [this message]
2011-06-09  5:59 ` Paolo Bonzini
2011-06-09  6:51 ` Jan Kiszka
2011-06-09 12:36 ` Andreas Färber
2011-06-09 15:14   ` Andreas Färber
2011-06-10 21:22 ` Edgar E. Iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=JBvG4Om2JmQG-UPj4ub1_6xsLAA@mail.gmail.com' \
    --to=cerbere@gmail.com \
    --cc=agraf@suse.de \
    --cc=andreas.faerber@web.de \
    --cc=jan.kiszka@siemens.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).