From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ide: Turn debug messages into assertions
Date: Mon, 9 May 2011 13:19:42 +0100 [thread overview]
Message-ID: <BANLkTi=MP8mYweT9D+S0WYf3tzg=G+-uxQ@mail.gmail.com> (raw)
In-Reply-To: <1304934742-5193-1-git-send-email-kwolf@redhat.com>
On Mon, May 9, 2011 at 10:52 AM, Kevin Wolf <kwolf@redhat.com> wrote:
> These printfs aren't really debug messages, but clearly indicate a bug if they
> ever become effective. Noone uses DEBUG_IDE, let's re-enable the check
> unconditionally and make it an assertion instead of printfs in the device
> emulation.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> hw/ide/pci.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
prev parent reply other threads:[~2011-05-09 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 9:52 [Qemu-devel] [PATCH] ide: Turn debug messages into assertions Kevin Wolf
2011-05-09 12:19 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=MP8mYweT9D+S0WYf3tzg=G+-uxQ@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).