From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-img resize: Fix option parsing
Date: Tue, 3 May 2011 12:22:13 +0100 [thread overview]
Message-ID: <BANLkTi=MmhbA34e_qYnZRrgohp_itnRmfQ@mail.gmail.com> (raw)
In-Reply-To: <1304067992-7088-1-git-send-email-kwolf@redhat.com>
On Fri, Apr 29, 2011 at 10:06 AM, Kevin Wolf <kwolf@redhat.com> wrote:
> For shrinking images, you're supposed to use a negative size. However, the
> leading minus makes getopt think that it's an option and so you get the help
> text if you don't use -- like in 'qemu-img resize test.img -- -1G'.
>
> This patch handles the size first and removes it from the argument list so that
> getopt won't even try to interpret it and you don't need -- any more.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qemu-img.c | 13 +++++++++++--
> 1 files changed, 11 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
prev parent reply other threads:[~2011-05-03 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 9:06 [Qemu-devel] [PATCH] qemu-img resize: Fix option parsing Kevin Wolf
2011-05-03 11:22 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=MmhbA34e_qYnZRrgohp_itnRmfQ@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).