From: Stefan Hajnoczi <stefanha@gmail.com>
To: Lluís <xscript@gmx.net>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/6] trace: generalize the "property" concept in the trace-events file
Date: Wed, 6 Apr 2011 11:53:48 +0100 [thread overview]
Message-ID: <BANLkTi=Oaqz21V07HD8q+x652C+amTEqXA@mail.gmail.com> (raw)
In-Reply-To: <20110404214913.9761.67286.stgit@ginnungagap.bsc.es>
On Mon, Apr 4, 2011 at 10:49 PM, Lluís <xscript@gmx.net> wrote:
> @@ -168,7 +168,7 @@ The st_change_trace_event_state() function can be used to enable or disable trac
> events at runtime inside QEMU:
>
> #include "trace.h"
> -
> +
Please leave the trailing whitespace, it's a workaround for wiki
syntax/formatting.
> @@ -222,9 +223,10 @@ linetoc_simple()
> {
> local name state
> name=$(get_name "$1")
> - state=$(get_state "$1")
> - if [ "$state" = "0" ] ; then
> - name=${name##disable }
> + if has_property "$1" "disable"; then
> + state="0"
> + else
> + state="1"
Or put another way (style decision, I won't complain if you leave it):
has_property "$1" "disable"
state=$?
Stefan
next prev parent reply other threads:[~2011-04-06 10:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 21:49 [Qemu-devel] [RFC][PATCH 0/6] trace-state: make the behaviour of "disable" consistent across all backends Lluís
2011-04-04 21:49 ` [Qemu-devel] [PATCH 1/6] trace: [ust] fix generation of 'trace.c' on events without args Lluís
2011-04-04 21:49 ` [Qemu-devel] [PATCH 2/6] trace: generalize the "property" concept in the trace-events file Lluís
2011-04-06 10:53 ` Stefan Hajnoczi [this message]
2011-04-04 21:49 ` [Qemu-devel] [PATCH 3/6] trace-state: always use the "nop" backend on events with the "disable" keyword Lluís
2011-04-06 11:04 ` [Qemu-devel] " Stefan Hajnoczi
2011-04-04 21:49 ` [Qemu-devel] [PATCH 4/6] trace-state: [simple] disable all trace points by default Lluís
2011-04-04 21:49 ` [Qemu-devel] [PATCH 5/6] trace-state: [simple] add "-trace events" argument to control initial state Lluís
2011-04-06 11:37 ` [Qemu-devel] " Stefan Hajnoczi
2011-04-06 14:15 ` Lluís
2011-04-06 20:30 ` Stefan Hajnoczi
2011-04-06 21:45 ` Lluís
2011-04-04 21:49 ` [Qemu-devel] [PATCH 6/6] trace: enable all events Lluís
2011-04-06 11:38 ` [Qemu-devel] " Stefan Hajnoczi
2011-04-05 13:30 ` [Qemu-devel] Re: [RFC][PATCH 0/6] trace-state: make the behaviour of "disable" consistent across all backends Stefan Hajnoczi
2011-04-06 11:42 ` Stefan Hajnoczi
2011-04-06 14:30 ` Fabien Chouteau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=Oaqz21V07HD8q+x652C+amTEqXA@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=xscript@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).