From: Alexandre Raymond <cerbere@gmail.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction
Date: Thu, 2 Jun 2011 09:27:42 -0400 [thread overview]
Message-ID: <BANLkTi=OedruypO6bf4-N0DQ6FJMyCR6dQ@mail.gmail.com> (raw)
In-Reply-To: <C277121A-7515-4CD2-85E1-BEEE51AC3960@web.de>
On Thu, Jun 2, 2011 at 6:13 AM, Andreas Färber <andreas.faerber@web.de> wrote:
> Am 02.06.2011 um 04:21 schrieb Alexandre Raymond:
>
>> Fix the following warning by including signal.h directly in qemu-common.h
>> ----8<----
>> iohandler.c: In function ‘qemu_init_child_watch’:
>> iohandler.c:172: warning: implicit declaration of function ‘sigaction’
>> iohandler.c:172: warning: nested extern declaration of ‘sigaction’
>> ----8<----
>>
>> Signed-off-by: Alexandre Raymond <cerbere@gmail.com>
>
> Tested-by: Andreas Färber <andreas.faerber@web.de>
>
> Why in qemu-common.h and not in iohandler.c though?
> If we put it into qemu-common.h, you should remove other inclusions of
> signal.h.
Well, I was simply following Anthony's advice from "[PATCH] #include
cleanlines" : "The idea behind qemu-common.h is to avoid direct
includes to help with portability."
Alexandre
next prev parent reply other threads:[~2011-06-02 13:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 2:21 [Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction Alexandre Raymond
2011-06-02 10:13 ` Andreas Färber
2011-06-02 13:27 ` Alexandre Raymond [this message]
2011-06-02 22:44 ` Stefan Hajnoczi
2011-06-02 22:55 ` Alexandre Raymond
2011-06-02 23:04 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=OedruypO6bf4-N0DQ6FJMyCR6dQ@mail.gmail.com' \
--to=cerbere@gmail.com \
--cc=andreas.faerber@web.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).