From: Blue Swirl <blauwirbel@gmail.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Avi Kivity <avi@redhat.com>,
qemu-devel Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] Optimize screendump
Date: Sun, 26 Jun 2011 20:52:58 +0300 [thread overview]
Message-ID: <BANLkTi=TB1AZ55_TJBA8YeNg+KeOm4jH2Q@mail.gmail.com> (raw)
In-Reply-To: <34D5F588-AC68-483A-9065-2E17730239BF@web.de>
On Thu, Jun 23, 2011 at 12:22 AM, Andreas Färber <andreas.faerber@web.de> wrote:
> Am 20.06.2011 um 15:11 schrieb Avi Kivity:
>
>> On 06/20/2011 03:33 PM, Jan Kiszka wrote:
>>>
>>> > --- a/hw/vga.c
>>> > +++ b/hw/vga.c
>>> > @@ -2349,15 +2349,19 @@ int ppm_save(const char *filename, struct
>>> > DisplaySurface *ds)
>>
>>> Unrelated to this patch, but why is this function located in vga.c and
>>> not in console.c?
>>
>> It's located in omap_lcdc.c as well. But it needs to be fully
>> generalized to be moved out (handle all PixelFormats).
>
> For the record, there's a similar function in tcx.c as well, and I have one
> coming in ibm8514.c.
The screen dumpers generate their output based on the current state of
the graphics card and the VRAM, this is why they are device specific.
A generic screen dumper (if possible) would read the data from display
surface. Maybe this should be done at the SDL/VNC/Spice/curses/dummy
level, but the output shouldn't change depending on the back end in
question.
next prev parent reply other threads:[~2011-06-26 17:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 8:12 [Qemu-devel] [PATCH v2] Optimize screendump Avi Kivity
2011-06-20 12:33 ` Jan Kiszka
2011-06-20 13:11 ` Avi Kivity
2011-06-22 21:22 ` Andreas Färber
2011-06-26 17:52 ` Blue Swirl [this message]
2011-06-20 15:39 ` Stefan Hajnoczi
2011-06-22 12:58 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=TB1AZ55_TJBA8YeNg+KeOm4jH2Q@mail.gmail.com' \
--to=blauwirbel@gmail.com \
--cc=andreas.faerber@web.de \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).