From: Peter Maydell <peter.maydell@linaro.org>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL] Remove unused function parameters
Date: Wed, 20 Apr 2011 11:57:57 +0100 [thread overview]
Message-ID: <BANLkTi=edj9v_ny9RbJ2uOb_=3Z25pvL9A@mail.gmail.com> (raw)
In-Reply-To: <20110420105355.GL6388@volta.aurel32.net>
On 20 April 2011 11:53, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On Wed, Apr 20, 2011 at 11:03:36AM +0200, Stefan Weil wrote:
>> Hello,
>>
>> I updated the first patch as suggested by Peter Maydell
>> (Fix [] typo, fix copy+paste error with SHA1 object name
>> in commit message). The rest is identical, so I don't
>> resend it to qemu-devel.
>
> Thanks, pulled. In the future please resend the patches on the mailing
> list anyway if they differ from the previous patches. This can be in the
> same thread as the pull. This is quite handy when you want to work on
> QEMU without Internet access.
Maybe we should document "how to send a pull request" on the wiki?
I remember having to quiz Anthony on irc about the preferred format
the first time I did one...
-- PMM
next prev parent reply other threads:[~2011-04-20 10:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 20:38 [Qemu-devel] [PATCH] Remove unneeded function parameter from gen_pc_load Stefan Weil
2011-04-13 21:05 ` Peter Maydell
2011-04-14 18:50 ` Stefan Weil
2011-04-17 18:27 ` Aurelien Jarno
2011-04-17 21:07 ` Stefan Weil
2011-04-17 21:34 ` Peter Maydell
2011-04-17 21:43 ` Aurelien Jarno
2011-04-18 16:35 ` Stefan Weil
2011-04-18 16:39 ` [Qemu-devel] [PATCH 1/2] Remove unused function parameters from gen_pc_load and rename the function Stefan Weil
2011-04-18 17:15 ` Peter Maydell
2011-04-20 9:03 ` [Qemu-devel] [PULL] Remove unused function parameters Stefan Weil
2011-04-20 10:53 ` Aurelien Jarno
2011-04-20 10:57 ` Peter Maydell [this message]
2011-04-18 16:39 ` [Qemu-devel] [PATCH 2/2] Remove unused function parameter from cpu_restore_state Stefan Weil
2011-04-18 17:28 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=edj9v_ny9RbJ2uOb_=3Z25pvL9A@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).