From: Peter Maydell <peter.maydell@linaro.org>
To: Alexandre Raymond <cerbere@gmail.com>
Cc: andreas.faerber@web.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V2 2/3] Cocoa: avoid displaying window when command-line contains '-h' or '-help'
Date: Sun, 29 May 2011 23:32:39 +0100 [thread overview]
Message-ID: <BANLkTi=jFFTObX0RWO6irm4PMXAxBDCrgg@mail.gmail.com> (raw)
In-Reply-To: <1306707770-14632-3-git-send-email-cerbere@gmail.com>
On 29 May 2011 23:22, Alexandre Raymond <cerbere@gmail.com> wrote:
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index 1ff1ac6..e1312d3 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -872,7 +872,8 @@ int main (int argc, const char * argv[]) {
> if (opt[1] == '-') {
> opt++;
> }
> - if (!strcmp(opt, "-vnc") ||
> + if (!strcmp(opt, "-h") || !strcmp(opt, "-help") ||
> + !strcmp(opt, "-vnc") ||
> !strcmp(opt, "-nographic") ||
> !strcmp(opt, "-version") ||
> !strcmp(opt, "-curses")) {
(1) presumably this doesn't work if you disable the display
with "-display none" ?
(2) it's pretty ugly and not very maintainable -- is there
some restructuring possible to avoid having to hardcode
information about qemu options into the ui code here?
(It also doesn't catch other cases where qemu prints some
information and exits immediately, like "-cpu ?".)
-- PMM
next prev parent reply other threads:[~2011-05-29 22:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-29 22:22 [Qemu-devel] [PATCH V2 0/3] Fix compilation issues under darwin Alexandre Raymond
2011-05-29 22:22 ` [Qemu-devel] [PATCH V2 1/3] Darwin: Fix incorrect check for fdatasync() in configure Alexandre Raymond
2011-05-29 23:36 ` Andreas Färber
2011-05-30 0:09 ` Alexandre Raymond
2011-05-30 2:32 ` Alexandre Raymond
2011-06-01 22:26 ` Andreas Färber
2011-05-29 22:22 ` [Qemu-devel] [PATCH V2 2/3] Cocoa: avoid displaying window when command-line contains '-h' or '-help' Alexandre Raymond
2011-05-29 22:32 ` Peter Maydell [this message]
2011-05-29 22:40 ` Alexandre Raymond
2011-06-01 23:05 ` Andreas Färber
2011-06-02 6:10 ` Peter Maydell
2011-06-01 22:16 ` Andreas Färber
2011-05-29 22:22 ` [Qemu-devel] [PATCH V2 3/3] Remove warning in printf due to type mismatch Alexandre Raymond
2011-06-01 21:13 ` Andreas Färber
2011-06-02 7:18 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=jFFTObX0RWO6irm4PMXAxBDCrgg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=andreas.faerber@web.de \
--cc=cerbere@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).