From: Peter Maydell <peter.maydell@linaro.org>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: Mike Frysinger <vapier@gentoo.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Enforce pselect6 sigset size restrictions
Date: Tue, 28 Jun 2011 12:54:14 +0100 [thread overview]
Message-ID: <BANLkTi=kg-fLj04LEA+vRka54f1N3=mDGA@mail.gmail.com> (raw)
In-Reply-To: <20110628115149.GA17577@afflict.kos.to>
On 28 June 2011 12:51, Riku Voipio <riku.voipio@iki.fi> wrote:
> On Tue, Jun 28, 2011 at 12:21:57PM +0100, Peter Maydell wrote:
>> Enforce the same restriction on the size of the sigset passed to
>> pselect6 as the Linux kernel does. This is both correct and silences
>> a gcc 4.6 warning about a write-only variable.
>
> Odd but true, after all the trouble of passing the size as packed variable,
> even the kernel bothers nothing but check that it matches with
> sizeof(sigset_t)...
I assume they're leaving the door open for implementing that properly
at some later date.
Incidentally, if the qemu target's sigset_t and the host's sigset_t
are different sizes then not just this syscall but I suspect all
the others that use sigset_t will have trouble. Luckily only one
flavour of MIPS has a non-standard sigset_t size :-)
-- PMM
next prev parent reply other threads:[~2011-06-28 11:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 11:21 [Qemu-devel] [PATCH] linux-user/syscall.c: Enforce pselect6 sigset size restrictions Peter Maydell
2011-06-28 11:51 ` Riku Voipio
2011-06-28 11:54 ` Peter Maydell [this message]
2011-06-28 16:14 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=kg-fLj04LEA+vRka54f1N3=mDGA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).