From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45237)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QbWs1-00056H-0W
	for qemu-devel@nongnu.org; Tue, 28 Jun 2011 07:54:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QbWrw-0002qi-9f
	for qemu-devel@nongnu.org; Tue, 28 Jun 2011 07:54:20 -0400
Received: from mail-pz0-f46.google.com ([209.85.210.46]:56216)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QbWrv-0002qW-OL
	for qemu-devel@nongnu.org; Tue, 28 Jun 2011 07:54:15 -0400
Received: by pzk9 with SMTP id 9so82044pzk.33
	for <qemu-devel@nongnu.org>; Tue, 28 Jun 2011 04:54:14 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20110628115149.GA17577@afflict.kos.to>
References: <1309260117-28334-1-git-send-email-peter.maydell@linaro.org>
	<20110628115149.GA17577@afflict.kos.to>
Date: Tue, 28 Jun 2011 12:54:14 +0100
Message-ID: <BANLkTi=kg-fLj04LEA+vRka54f1N3=mDGA@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Enforce pselect6
	sigset size restrictions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: Mike Frysinger <vapier@gentoo.org>, qemu-devel@nongnu.org

On 28 June 2011 12:51, Riku Voipio <riku.voipio@iki.fi> wrote:
> On Tue, Jun 28, 2011 at 12:21:57PM +0100, Peter Maydell wrote:
>> Enforce the same restriction on the size of the sigset passed to
>> pselect6 as the Linux kernel does. This is both correct and silences
>> a gcc 4.6 warning about a write-only variable.
>
> Odd but true, after all the trouble of passing the size as packed variable,
> even the kernel bothers nothing but check that it matches with
> sizeof(sigset_t)...

I assume they're leaving the door open for implementing that properly
at some later date.

Incidentally, if the qemu target's sigset_t and the host's sigset_t
are different sizes then not just this syscall but I suspect all
the others that use sigset_t will have trouble. Luckily only one
flavour of MIPS has a non-standard sigset_t size :-)

-- PMM