From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52091)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Q9Sii-0007mM-He
	for qemu-devel@nongnu.org; Mon, 11 Apr 2011 21:48:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Q9Krl-00058P-1N
	for qemu-devel@nongnu.org; Mon, 11 Apr 2011 13:25:34 -0400
Received: from mail-vw0-f45.google.com ([209.85.212.45]:59530)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Q9Krk-00058I-Rl
	for qemu-devel@nongnu.org; Mon, 11 Apr 2011 13:25:32 -0400
Received: by vws17 with SMTP id 17so5002886vws.4
	for <qemu-devel@nongnu.org>; Mon, 11 Apr 2011 10:25:32 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <5F214CCC-08E4-444D-8317-C7D4F20D4150@suse.de>
References: <BANLkTimM42+rbZLG3zioZ0XNfahy=aGHeA@mail.gmail.com>
	<B67107F9-BA40-436F-9659-72B91FDAA62A@suse.de>
	<20110411043028.GN3151@yookeroo>
	<5F214CCC-08E4-444D-8317-C7D4F20D4150@suse.de>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Mon, 11 Apr 2011 20:25:12 +0300
Message-ID: <BANLkTi=m+AUJbeEB5yeccum9pDXVLhPTYg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] ppc: remove a write-only variable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: QEMU-devel Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, David Gibson <david@gibson.dropbear.id.au>

On Mon, Apr 11, 2011 at 10:48 AM, Alexander Graf <agraf@suse.de> wrote:
>
> On 11.04.2011, at 06:30, David Gibson wrote:
>
>> On Sat, Apr 09, 2011 at 05:28:06PM +0200, Alexander Graf wrote:
>>>
>>>
>>>
>>>
>>> Am 09.04.2011 um 16:56 schrieb Blue Swirl <blauwirbel@gmail.com>:
>>>
>>>> Remove a write-only variable, spotted by GCC 4.6.0:
>>>> /src/qemu/hw/ppc.c: In function 'power7_set_irq':
>>>> /src/qemu/hw/ppc.c:255:9: error: variable 'cur_level' set but not used
>>>> [-Werror=3Dunused-but-set-variable]
>>>>
>>>> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>>>> ---
>>>> hw/ppc.c | =C2=A0 =C2=A02 --
>>>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/hw/ppc.c b/hw/ppc.c
>>>> index dabb816..1873328 100644
>>>> --- a/hw/ppc.c
>>>> +++ b/hw/ppc.c
>>>> @@ -252,11 +252,9 @@ void ppc970_irq_init (CPUState *env)
>>>> static void power7_set_irq (void *opaque, int pin, int level)
>>>> {
>>>> =C2=A0 =C2=A0CPUState *env =3D opaque;
>>>> - =C2=A0 =C2=A0int cur_level;
>>>>
>>>> =C2=A0 =C2=A0LOG_IRQ("%s: env %p pin %d level %d\n", __func__,
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0env, pin, level=
);
>>>> - =C2=A0 =C2=A0cur_level =3D (env->irq_input_state >> pin) & 1;
>>>
>>> David, Ben?
>>
>> That should be fine. =C2=A0It's a hang over from the ppc970 code which I
>> adapted.
>
> Alright.
>
> Acked-by: Alexander Graf <agraf@suse.de>
>
> Blue, mind to apply it directly? That's easier than going through my tree=
.

Thanks for the ack, applied.