From: Peter Maydell <peter.maydell@linaro.org>
To: Lluís <xscript@gmx.net>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 1/4] [arm] trivial whitespace/indentation fixes
Date: Wed, 13 Apr 2011 18:16:55 +0100 [thread overview]
Message-ID: <BANLkTi=n5Js-3LMfJ_rHzKCkRPX198BpqQ@mail.gmail.com> (raw)
In-Reply-To: <20110413163816.20067.32914.stgit@ginnungagap.bsc.es>
On 13 April 2011 17:38, Lluís <xscript@gmx.net> wrote:
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
> target-arm/helper.c | 246 ++++++++++++++++++++++----------------------
> target-arm/iwmmxt_helper.c | 28 +++--
> target-arm/translate.c | 26 ++---
> 3 files changed, 150 insertions(+), 150 deletions(-)
My preference is not to do large-scale whitespace changes
unless the code's being touched in that area anyway, so
I'd prefer this not to be applied.
(They make things painful for forks and branches, and
they make git blame less useful; disadvantages outweigh
the minor benefits of the cleanup IMHO.)
-- PMM
next prev parent reply other threads:[~2011-04-13 17:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 16:38 [Qemu-devel] [PATCH 1/4] [arm] trivial whitespace/indentation fixes Lluís
2011-04-13 16:38 ` [Qemu-devel] [PATCH 2/4] [arm] move helpers.h to helper.h Lluís
2011-04-18 19:18 ` Aurelien Jarno
2011-04-13 16:38 ` [Qemu-devel] [PATCH 3/4] [m68k] trivial whitespace/indentation fixes Lluís
2011-04-13 16:38 ` [Qemu-devel] [PATCH 4/4] [m68k] move helpers.h to helper.h Lluís
2011-04-13 17:16 ` Peter Maydell [this message]
2011-04-13 18:34 ` [Qemu-devel] [PATCH 1/4] [arm] trivial whitespace/indentation fixes Aurelien Jarno
2011-04-13 20:06 ` Lluís
2011-04-13 20:09 ` Lluís
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=n5Js-3LMfJ_rHzKCkRPX198BpqQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=xscript@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).