From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] Register only one qbus_reset_all_fn() for system bus
Date: Mon, 4 Apr 2011 15:58:39 +0400 [thread overview]
Message-ID: <BANLkTi=nPG4RBKvUB=q7-oK0Ozh4f5zWoQ@mail.gmail.com> (raw)
In-Reply-To: <20110403102639.GC11748@valinux.co.jp>
On 4/3/11, Isaku Yamahata <yamahata@valinux.co.jp> wrote:
> On Sat, Apr 02, 2011 at 06:47:37PM +0400, Dmitry Eremin-Solenikov wrote:
>> On 4/2/11, Isaku Yamahata <yamahata@valinux.co.jp> wrote:
>> >> Have you verified that all bus devices have been qdevified since this
>> >> code has been added? I wouldn't bet it is the case.
>> >
>> > I think his analysis is valid. So how about the following patch.
>>
>> Could you please point me to an example of devices for which this check is
>> required.
>
> Although I don't have any example, I bet to not change the reset order.
> If you check all the devices, it's good.
The question is which devices to check as lots of devices are already
converted to qdev. Is it correct that we should check only devices
which register a child bus with parent device set, and the thing that we
should check is the fact that the parent reset function also causes
the bus reset?
--
With best wishes
Dmitry
next prev parent reply other threads:[~2011-04-04 11:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-20 23:08 [Qemu-devel] [PATCH] Register only one qbus_reset_all_fn() for system bus Dmitry Eremin-Solenikov
2011-04-01 19:57 ` Aurelien Jarno
2011-04-02 0:12 ` Isaku Yamahata
2011-04-02 14:47 ` Dmitry Eremin-Solenikov
2011-04-03 10:26 ` Isaku Yamahata
2011-04-04 11:58 ` Dmitry Eremin-Solenikov [this message]
2011-04-04 13:54 ` Isaku Yamahata
-- strict thread matches above, loose matches on Subject: below --
2011-03-10 8:53 Dmitry Eremin-Solenikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=nPG4RBKvUB=q7-oK0Ozh4f5zWoQ@mail.gmail.com' \
--to=dbaryshkov@gmail.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).