qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: stefano.stabellini@eu.citrix.com
Cc: anthony.perard@citrix.com, xen-devel@lists.xensource.com,
	qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH v2] xen_console: support the new extended xenstore protocol
Date: Tue, 28 Jun 2011 16:02:11 +0100	[thread overview]
Message-ID: <BANLkTi=px9xd62yT7OBtMUvF--FQkXfVpg@mail.gmail.com> (raw)
In-Reply-To: <1309272956-6221-1-git-send-email-stefano.stabellini@eu.citrix.com>

On 28 June 2011 15:55,  <stefano.stabellini@eu.citrix.com> wrote:
> +    xs = xs_daemon_open();
> +    if (xs == NULL) {
> +        fprintf(stderr, "Could not contact XenStore\n");
> +        goto out;
> +    }

> +out:
> +    free(path);
> +    xs_daemon_close(xs);

Google suggests xs_daemon_close(NULL) will crash...

-- PMM

  reply	other threads:[~2011-06-28 15:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-28 14:55 [Qemu-devel] [PATCH v2] xen_console: support the new extended xenstore protocol stefano.stabellini
2011-06-28 15:02 ` Peter Maydell [this message]
2011-06-28 15:06   ` [Qemu-devel] [Xen-devel] " Ian Campbell
2011-06-28 15:15     ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=px9xd62yT7OBtMUvF--FQkXfVpg@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=agraf@suse.de \
    --cc=anthony.perard@citrix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).