From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35015)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QbZns-0000MQ-MC
	for qemu-devel@nongnu.org; Tue, 28 Jun 2011 11:02:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QbZnq-0001tB-0a
	for qemu-devel@nongnu.org; Tue, 28 Jun 2011 11:02:16 -0400
Received: from mail-pz0-f46.google.com ([209.85.210.46]:49785)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QbZnp-0001ss-5N
	for qemu-devel@nongnu.org; Tue, 28 Jun 2011 11:02:13 -0400
Received: by pzk9 with SMTP id 9so247547pzk.33
	for <qemu-devel@nongnu.org>; Tue, 28 Jun 2011 08:02:12 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1309272956-6221-1-git-send-email-stefano.stabellini@eu.citrix.com>
References: <1309272956-6221-1-git-send-email-stefano.stabellini@eu.citrix.com>
Date: Tue, 28 Jun 2011 16:02:11 +0100
Message-ID: <BANLkTi=px9xd62yT7OBtMUvF--FQkXfVpg@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2] xen_console: support the new extended
	xenstore protocol
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: stefano.stabellini@eu.citrix.com
Cc: anthony.perard@citrix.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org, agraf@suse.de

On 28 June 2011 15:55,  <stefano.stabellini@eu.citrix.com> wrote:
> + =C2=A0 =C2=A0xs =3D xs_daemon_open();
> + =C2=A0 =C2=A0if (xs =3D=3D NULL) {
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0fprintf(stderr, "Could not contact XenStore\=
n");
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0goto out;
> + =C2=A0 =C2=A0}

> +out:
> + =C2=A0 =C2=A0free(path);
> + =C2=A0 =C2=A0xs_daemon_close(xs);

Google suggests xs_daemon_close(NULL) will crash...

-- PMM