From: Sassan Panahinejad <sassan@sassan.me.uk>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix bug with virtio-9p fsync
Date: Tue, 26 Apr 2011 14:29:07 +0100 [thread overview]
Message-ID: <BANLkTi=vM8S+Mr0Fe2_mg+DsHxNYux+wHQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTim=FQDyH2nW81VtkXM3x_snTA=bag@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
On 26 April 2011 13:58, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> What about P9_FID_XATTR, seems like we have the same issue there too?
>
> wstat, lock, and getlock need closer auditing and perhaps fixing.
>
> Stefan
>
Sorry, forgot to hit reply-to-all.
Yes, it is probable that those functions will suffer from the same bug.
I will have to study XATTR and see how that will be affected. I don't know
whether it is possible for these functions to be called for XATTR, and if it
is then I do not know the proper way to handle it.
Perhaps we should have some function or macro to obtain the correct FD from
an fidp structure, which could be used for fsync, wstat, lock and getlock?
Sassan
[-- Attachment #2: Type: text/html, Size: 1076 bytes --]
next prev parent reply other threads:[~2011-04-26 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 17:54 [Qemu-devel] [PATCH] Fix bug with virtio-9p fsync Sassan Panahinejad
2011-04-26 9:18 ` Stefan Hajnoczi
2011-04-26 12:14 ` Sassan Panahinejad
2011-04-26 12:58 ` Stefan Hajnoczi
2011-04-26 13:29 ` Sassan Panahinejad [this message]
2011-04-26 14:25 ` Venkateswararao Jujjuri
2011-04-26 16:51 ` Sassan Panahinejad
2011-04-26 21:12 ` Venkateswararao Jujjuri
2011-04-27 11:41 ` Sassan Panahinejad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=vM8S+Mr0Fe2_mg+DsHxNYux+wHQ@mail.gmail.com' \
--to=sassan@sassan.me.uk \
--cc=jvrao@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).