[Qemu-devel] [PATCH 0/12] Adding VMDK monolithic flat support

[Qemu-devel] [PATCH 0/12] Adding VMDK monolithic flat support

[Fam Zheng]

This is a split patch series of the previous monolithic flat support
version, with improvements according to Kevin's comments.

Original comment:
VMDK multiple file images can not be recognized for now. This patch is
adding monolithic flat support to it, that is the image type with two
files, one text descriptor file and a plain data file. This type of
image can be created in VMWare, with the options "allocate all disk
space now" and "store virtual disk as a single file" checked.

A VmdkExtent structure is introduced to hold the image "extent"
information, which makes further adding multi extents support of VMDK
easy. An image creating option "flat" is added for creating flat
(preallocated) image.

---

 block/vmdk.c |  908 +++++++++++++++++++++++++++++++++++++++++-----------------
 block_int.h  |    2 +
 qemu-img.c   |    6 +-
 3 files changed, 649 insertions(+), 267 deletions(-)

Re: [Qemu-devel] [PATCH 0/12] Adding VMDK monolithic flat support

[Stefan Hajnoczi]

On Sat, Jun 4, 2011 at 1:39 AM, Fam Zheng <famcool@gmail.com> wrote:
> This is a split patch series of the previous monolithic flat support
> version, with improvements according to Kevin's comments.

Thanks for these patches!  I have left review comments for this series.

Eventually you will touch most of the vmdk code so I think using QEMU
coding style, making parsing robust, and using -errno return values
instead of just 0/-1 should be done.  The existing code doesn't do
these things so it will be a little extra work but worth it in order
to make vmdk a more modern, first-class block driver in QEMU.

Stefan