From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QG3mM-0007vW-Id for qemu-devel@nongnu.org; Sat, 30 Apr 2011 02:35:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QG3mL-0008TO-IY for qemu-devel@nongnu.org; Sat, 30 Apr 2011 02:35:46 -0400 Received: from mail-qy0-f173.google.com ([209.85.216.173]:36461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QG3mL-0008TB-Er for qemu-devel@nongnu.org; Sat, 30 Apr 2011 02:35:45 -0400 Received: by qyk36 with SMTP id 36so675491qyk.4 for ; Fri, 29 Apr 2011 23:35:45 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4DBB3E0C.9000004@twiddle.net> References: <1304023875-25040-1-git-send-email-rth@twiddle.net> <1304023875-25040-3-git-send-email-rth@twiddle.net> <4DBB3E0C.9000004@twiddle.net> From: Blue Swirl Date: Sat, 30 Apr 2011 09:35:25 +0300 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 02/33] gdbserver: Don't deliver TIMER interrupts when SSTEP_NOIRQ either. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Sat, Apr 30, 2011 at 1:39 AM, Richard Henderson wrote: > On 04/29/2011 01:53 PM, Blue Swirl wrote: >>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 CPU_INTERRUPT_TIMER | >> >> Grepping for CPU_INTERRUPT_TIMER shows that the flag isn't ever set, >> only cleared or checked. How >> about removing the flag instead? > > Certainly Sparc and MIPS shouldn't check it if they don't set it. It's not used by any architecture now. > For Alpha, I do want to easily discriminate between device, timer, > and inter-processor interrupts. =C2=A0I'm currently (ab)using the i386 > CPU_INTERRUPT_SMI name for the IPI; I could abuse, say, FIQ for > my timer bit, but it seems nicer to simply keep the TIMER name. Since Alpha would be the first user, you can even rename it if you like.