From: Blue Swirl <blauwirbel@gmail.com>
To: malc <av1474@comtv.ru>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 14/18] TCG/PPC: use TCG_REG_CALL_STACK instead of TCG_REG_R1
Date: Tue, 21 Jun 2011 00:23:10 +0300 [thread overview]
Message-ID: <BANLkTik+Gww7FCBTnsrm06rMfhia+q+vzQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1106200211370.2610@linmac>
On Mon, Jun 20, 2011 at 1:14 AM, malc <av1474@comtv.ru> wrote:
> On Mon, 20 Jun 2011, Blue Swirl wrote:
>
>> Use TCG_REG_CALL_STACK instead of TCG_REG_R1 etc. for consistency.
>
> You spell it TCG_REG_CALL_STACK in the subject/comment but
> REG_CALL_STACK in the patch, which suggest that it was never
> even compile tested.
Actually I seem to have used both versions. I didn't compile test, but
to make matters even worse, I didn't even read any reference manuals
or ABI descriptions for any of these patches but based all this on
bits gathered from */tcg-target.[ch]. But is the patch otherwise OK?
;-)
next prev parent reply other threads:[~2011-06-20 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-19 21:06 [Qemu-devel] [PATCH 14/18] TCG/PPC: use TCG_REG_CALL_STACK instead of TCG_REG_R1 Blue Swirl
2011-06-19 22:14 ` malc
2011-06-20 21:23 ` Blue Swirl [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-28 10:08 Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTik+Gww7FCBTnsrm06rMfhia+q+vzQ@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).