From: ronnie sahlberg <ronniesahlberg@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] iSCSI support for QEMU
Date: Fri, 22 Apr 2011 06:25:26 +1000 [thread overview]
Message-ID: <BANLkTik-W8R59Nb6ihBSyhaQOa3m1FrVYQ@mail.gmail.com> (raw)
In-Reply-To: <20110421124938.GB27317@lst.de>
On Thu, Apr 21, 2011 at 10:49 PM, Christoph Hellwig <hch@lst.de> wrote:
> On Thu, Apr 21, 2011 at 09:36:12PM +1000, ronnie sahlberg wrote:
>> There are some high-volume arrays that advertise support but fail any
>> cdb with FUA, FUA_NV bits set with sense, so it needs to be made optional.
>
> Which on would that be? Linux uses the FUA bit if the device advertises support
> via the DPOFUA bit since 2005, and prints a warning if a FUA write fails,
> and since last year even fails the request hard. I'd be really surprised
> if a common device fails FUA writes and we didn't know about it by now.
>
> Either way you'll have to still guarantee data made it to non-volatile
> storage for cache=writethrough mode, either by disabling the WCE bit
> using MODE SELECT, or by flushing the cache after every write.
>
Thankyou for your patience.
I understand and I have updated the patch to set FUA when the _WB flag
is not set.
regards
ronnie sahlberg
next prev parent reply other threads:[~2011-04-21 20:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 8:43 [Qemu-devel] iSCSI support for QEMU Ronnie Sahlberg
2011-04-21 8:43 ` [Qemu-devel] [PATCH] iSCSI block driver support Ronnie Sahlberg
2011-04-21 8:50 ` [Qemu-devel] iSCSI support for QEMU Christoph Hellwig
2011-04-21 8:58 ` ronnie sahlberg
2011-04-21 9:09 ` Christoph Hellwig
2011-04-21 9:28 ` ronnie sahlberg
2011-04-21 10:58 ` Stefan Hajnoczi
2011-04-21 11:12 ` ronnie sahlberg
2011-04-21 11:21 ` Stefan Hajnoczi
2011-04-21 11:36 ` ronnie sahlberg
2011-04-21 11:44 ` Kevin Wolf
2011-04-21 12:08 ` Stefan Hajnoczi
2011-04-21 12:49 ` Christoph Hellwig
2011-04-21 20:25 ` ronnie sahlberg [this message]
2011-04-21 9:47 ` ronnie sahlberg
-- strict thread matches above, loose matches on Subject: below --
2011-06-12 2:54 ronnie sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTik-W8R59Nb6ihBSyhaQOa3m1FrVYQ@mail.gmail.com \
--to=ronniesahlberg@gmail.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).