From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCGuT-0006pT-8w for qemu-devel@nongnu.org; Tue, 19 Apr 2011 15:48:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCGuK-0003Zo-5C for qemu-devel@nongnu.org; Tue, 19 Apr 2011 15:48:29 -0400 MIME-Version: 1.0 In-Reply-To: References: <1303203461-30776-1-git-send-email-peter.maydell@linaro.org> Date: Tue, 19 Apr 2011 20:48:18 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] configure: Make epoll_create1 test work around SPARC glibc bug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org On 19 April 2011 20:37, Blue Swirl wrote: > On Tue, Apr 19, 2011 at 11:57 AM, Peter Maydell > wrote: >> Work around a SPARC glibc bug which caused the epoll_create1 configure >> test to wrongly claim that the function was present. Some versions of >> SPARC glibc provided the function in the library but didn't declare >> it in the include file; the result is that gcc warns about an implicit >> declaration but a link succeeds. So we build the configure test with >> -Werror to avoid the test passing but then a -Werror qemu build >> failing. > > But then epoll would not be used. I think that's fine -- on a system which isn't advertising epoll in its include files we shouldn't be trying to use it. It might be buggy, or not the same function at all, for instance. Anybody who actually cares about epoll can upgrade their libc :-) -- PMM