From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46993 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7R8X-0003gt-Ef for qemu-devel@nongnu.org; Wed, 06 Apr 2011 07:43:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7R8W-0004m9-Fi for qemu-devel@nongnu.org; Wed, 06 Apr 2011 07:43:01 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:53378) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7R8W-0004lv-Bm for qemu-devel@nongnu.org; Wed, 06 Apr 2011 07:43:00 -0400 Received: by gwb19 with SMTP id 19so453342gwb.4 for ; Wed, 06 Apr 2011 04:42:59 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20110404214900.9761.49418.stgit@ginnungagap.bsc.es> Date: Wed, 6 Apr 2011 12:42:59 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [RFC][PATCH 0/6] trace-state: make the behaviour of "disable" consistent across all backends List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Llu=EDs?= Cc: qemu-devel@nongnu.org, Fabien Chouteau , Prerna Saxena On Tue, Apr 5, 2011 at 2:30 PM, Stefan Hajnoczi wrote: > On Mon, Apr 4, 2011 at 10:49 PM, Llu=EDs wrote: >> This patch defines the "disable" trace event state to always use the "no= p" >> backend. >> >> As a side-effect, all events are now enabled (without "disable") by defa= ult, as >> all backends (except "stderr") have programmatic support for dynamically >> (de)activating each trace event. >> >> In order to make this true, the "simple" backend now has a "-trace >> events=3D" argument to let the user select which events must be en= abled from >> the very beginning. >> >> Signed-off-by: Llu=EDs Vilanova >> --- >> >> Llu=EDs Vilanova (6): >> =A0 =A0 =A0trace: [ust] fix generation of 'trace.c' on events without ar= gs >> =A0 =A0 =A0trace: generalize the "property" concept in the trace-events = file >> =A0 =A0 =A0trace-state: always use the "nop" backend on events with the = "disable" keyword >> =A0 =A0 =A0trace-state: [simple] disable all trace points by default >> =A0 =A0 =A0trace-state: [simple] add "-trace events" argument to control= initial state >> =A0 =A0 =A0trace: enable all events >> >> >> =A0docs/tracing.txt =A0| =A0 12 +- >> =A0qemu-config.c =A0 =A0 | =A0 =A05 + >> =A0qemu-options.hx =A0 | =A0 18 ++ >> =A0scripts/tracetool | =A0 88 +++++------- >> =A0trace-events =A0 =A0 =A0| =A0385 ++++++++++++++++++++++++++----------= ----------------- >> =A0vl.c =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 94 ++++++++----- >> =A06 files changed, 313 insertions(+), 289 deletions(-) > > Excellent, thanks for implementing this. =A0I'll review the patches in > detail shortly. I've left feedback on the individual patches. This is a nice cleanup, thanks for doing this work! The stderr backend is impacted - but not severely. You now need to disable all trace events that should not generate output. Previously it was the opposite; you needed to enable all trace events that should generate output. Adding Prerna (simpletrace) and Fabien (stderr) on CC so they can take a lo= ok. I'd like to merge v2 into my tracing tree and send the qemu.git maintainer a pull request soon. Stefan