From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMR3t-0003Lg-7X for qemu-devel@nongnu.org; Tue, 17 May 2011 16:40:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMR3s-0004rl-5e for qemu-devel@nongnu.org; Tue, 17 May 2011 16:40:13 -0400 Received: from mail-qw0-f45.google.com ([209.85.216.45]:48958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMR3s-0004rh-2h for qemu-devel@nongnu.org; Tue, 17 May 2011 16:40:12 -0400 Received: by qwj8 with SMTP id 8so542288qwj.4 for ; Tue, 17 May 2011 13:40:11 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4DD1E1DD.3060605@cisco.com> References: <1305575782-31766-1-git-send-email-kraxel@redhat.com> <1305575782-31766-19-git-send-email-kraxel@redhat.com> <4DD1E1DD.3060605@cisco.com> From: Blue Swirl Date: Tue, 17 May 2011 23:39:51 +0300 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Ahern Cc: Gerd Hoffmann , qemu-devel@nongnu.org On Tue, May 17, 2011 at 5:47 AM, David Ahern wrote: > > > On 05/16/11 13:56, Gerd Hoffmann wrote: >> This patch finally merges the EHCI host adapter aka USB 2.0 support. >> >> Based on git://git.kiszka.org/qemu.git ehci >> >> Changes: >> =C2=A0 - Adapt to recent changes in the usb subsystem. >> =C2=A0 - Don't create device automagically, use -device instead. >> =C2=A0 - Add quickstart text file, see docs/usb2.txt. >> =C2=A0 - A bunch of codestyle fixups. >> =C2=A0 - Add authors+contributers list. >> =C2=A0 - Zap EHCI_NOMICROFRAMES, qemu can't handle a 8 kHz >> =C2=A0 =C2=A0 wakeup rate anyway. >> =C2=A0 - A few bug fixes. >> >> Signed-off-by: Gerd Hoffmann > > As someone who spent a significant amount of time working on the EHCI > code last year I am absolutely not ok with this. The entire contribution > history for EHCI lost - and for no reason. The inclusion of EHCI into > qemu can be done in such a way as to maintain the history. The development history (implement a feature, fix bugs, implement another, fix bugs etc) is not interesting and pulling it would make bisection and other bugfixing more difficult. The patches should not add known broken features and fix them next. Instead, patches should add one simple, bug free feature at a time. This also makes it possible for some of them to be committed before others, while others may get rejected and may need major rework. The patches for EHCI are just like other patches.