From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTFDW-0005Zi-DU for qemu-devel@nongnu.org; Sun, 05 Jun 2011 11:26:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QTFDU-0004P4-TF for qemu-devel@nongnu.org; Sun, 05 Jun 2011 11:26:18 -0400 Received: from mail-qw0-f45.google.com ([209.85.216.45]:53383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTFDU-0004Na-FP for qemu-devel@nongnu.org; Sun, 05 Jun 2011 11:26:16 -0400 Received: by qwj8 with SMTP id 8so1657727qwj.4 for ; Sun, 05 Jun 2011 08:26:15 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1307105826-21517-1-git-send-email-pbonzini@redhat.com> References: <1307105826-21517-1-git-send-email-pbonzini@redhat.com> From: Blue Swirl Date: Sun, 5 Jun 2011 18:25:55 +0300 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] scsi: fix tracing of scsi requests with simple backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Thanks, applied. On Fri, Jun 3, 2011 at 3:57 PM, Paolo Bonzini wrote: > The simple backend only supports a maximum of 6 arguments. =C2=A0Split th= e > scsi_req_parsed event in two parts to cope with the limit. > > Signed-off-by: Paolo Bonzini > --- > =C2=A0hw/scsi-bus.c | =C2=A0 =C2=A06 +++++- > =C2=A0trace-events =C2=A0| =C2=A0 =C2=A03 ++- > =C2=A02 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c > index 837f24e..ad6a730 100644 > --- a/hw/scsi-bus.c > +++ b/hw/scsi-bus.c > @@ -413,7 +413,11 @@ int scsi_req_parse(SCSIRequest *req, uint8_t *buf) > =C2=A0 =C2=A0 scsi_req_xfer_mode(req); > =C2=A0 =C2=A0 req->cmd.lba =3D scsi_req_lba(req); > =C2=A0 =C2=A0 trace_scsi_req_parsed(req->dev->id, req->lun, req->tag, buf= [0], > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0req->cmd.mode, req->cmd.xfer, req->cmd.lba); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0req->cmd.mode, req->cmd.xfer); > + =C2=A0 =C2=A0if (req->cmd.lba !=3D -1) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0trace_scsi_req_parsed_lba(req->dev->id, req-= >lun, req->tag, buf[0], > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0req->cmd.lba); > + =C2=A0 =C2=A0} > =C2=A0 =C2=A0 return 0; > =C2=A0} > > diff --git a/trace-events b/trace-events > index 3137a15..e0e9574 100644 > --- a/trace-events > +++ b/trace-events > @@ -210,7 +210,8 @@ disable scsi_req_alloc(int target, int lun, int tag) = "target %d lun %d tag %d" > =C2=A0disable scsi_req_data(int target, int lun, int tag, int len) "targe= t %d lun %d tag %d len %d" > =C2=A0disable scsi_req_dequeue(int target, int lun, int tag) "target %d l= un %d tag %d" > =C2=A0disable scsi_req_continue(int target, int lun, int tag) "target %d = lun %d tag %d" > -disable scsi_req_parsed(int target, int lun, int tag, int cmd, int mode,= int xfer, uint64_t lba) "target %d lun %d tag %d command %d dir %d length = %d lba %"PRIu64"" > +disable scsi_req_parsed(int target, int lun, int tag, int cmd, int mode,= int xfer) "target %d lun %d tag %d command %d dir %d length %d" > +disable scsi_req_parsed_lba(int target, int lun, int tag, int cmd, uint6= 4_t lba) "target %d lun %d tag %d command %d lba %"PRIu64"" > =C2=A0disable scsi_req_parse_bad(int target, int lun, int tag, int cmd) "= target %d lun %d tag %d command %d" > > =C2=A0# vl.c > -- > 1.7.4.4 > > >