From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36780)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QUK6T-0006I4-5E
	for qemu-devel@nongnu.org; Wed, 08 Jun 2011 10:51:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QUK6N-0003z7-IX
	for qemu-devel@nongnu.org; Wed, 08 Jun 2011 10:51:28 -0400
Received: from mail-pz0-f45.google.com ([209.85.210.45]:65405)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QUK6N-0003xR-0m
	for qemu-devel@nongnu.org; Wed, 08 Jun 2011 10:51:23 -0400
Received: by pzk30 with SMTP id 30so291646pzk.4
	for <qemu-devel@nongnu.org>; Wed, 08 Jun 2011 07:51:21 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4DEF8997.7050108@siemens.com>
References: <cover.1307542247.git.jan.kiszka@siemens.com>
	<b7e14da2dbade9affee696a5997db1df5019ce43.1307542247.git.jan.kiszka@siemens.com>
	<BANLkTikUc8Dr8hYMgUqbLjbwBPWrbVvEyQ@mail.gmail.com>
	<4DEF8997.7050108@siemens.com>
Date: Wed, 8 Jun 2011 15:51:21 +0100
Message-ID: <BANLkTikBMgqEpKmb_jvqaRKWZWLuHxRH5A@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 01/12] Add kernel header update script
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>, Marcelo Tosatti <mtosatti@redhat.com>, Alexander Graf <agraf@suse.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <andreas.faerber@web.de>, Avi Kivity <avi@redhat.com>, Christoph Hellwig <hch@lst.de>

2011/6/8 Jan Kiszka <jan.kiszka@siemens.com>:
> On 2011-06-08 16:33, Peter Maydell wrote:
>> On 8 June 2011 15:10, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>> +tmpdir=$TMPDIR/.tmp-hdrs-$$
>>
>> Better (safer) to use mktemp, I think.
>
> Is that portable? I don't think so.

We don't expect every random end user to run this script, though,
right? We already use mktemp in scripts/refresh-pxe-roms.sh, for
instance.

-- PMM