From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QX1Ic-0002PI-T0 for qemu-devel@nongnu.org; Wed, 15 Jun 2011 21:23:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QX1Ib-0003VP-EP for qemu-devel@nongnu.org; Wed, 15 Jun 2011 21:23:10 -0400 Received: from mail-ww0-f53.google.com ([74.125.82.53]:58415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QX1Ib-0003VL-66 for qemu-devel@nongnu.org; Wed, 15 Jun 2011 21:23:09 -0400 Received: by wwj40 with SMTP id 40so931745wwj.10 for ; Wed, 15 Jun 2011 18:23:08 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <67D16361-9E4A-489C-B671-B7D08A50123F@web.de> References: <1308019077-61957-1-git-send-email-andreas.faerber@web.de> <1308019077-61957-2-git-send-email-andreas.faerber@web.de> <1308019077-61957-3-git-send-email-andreas.faerber@web.de> <1308019077-61957-4-git-send-email-andreas.faerber@web.de> <1308019077-61957-5-git-send-email-andreas.faerber@web.de> <1308019077-61957-6-git-send-email-andreas.faerber@web.de> <1308019077-61957-7-git-send-email-andreas.faerber@web.de> <1308019077-61957-8-git-send-email-andreas.faerber@web.de> <1308019077-61957-9-git-send-email-andreas.faerber@web.de> <1308019077-61957-10-git-send-email-andreas.faerber@web.de> <1308019077-61957-11-git-send-email-andreas.faerber@web.de> <1308019077-61957-12-git-send-email-andreas.faerber@web.de> <1308019077-61957-13-git-send-email-andreas.faerber@web.de> <1308019077-61957-14-git-send-email-andreas.faerber@web.de> <1308019077-61957-15-git-send-email-andreas.faerber@web.de> <1308019077-61957-16-git-send-email-andreas.faerber@web.de> <1308019077-61957-18-git-send-email-andreas.faerber@web.de> <1308019077-61957-19-git-send-email-andreas.faerber@web.de> <1308019077-61957-20-git-send-email-andreas.faerber@web.de> <1308019077-61957-21-git-send-email-andreas.faerber@web.de> <1308019077-61957-22-git-send-email-andreas.faerber@web.de> <1308019077-61957-23-git-send-email-andreas.faerber@web.de> <1308019077-61957-24-git-send-email-andreas.faerber@web.de> <67D16361-9E4A-489C-B671-B7D08A50123F@web.de> From: Roy Tam Date: Thu, 16 Jun 2011 09:22:48 +0800 Message-ID: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC 23/23] 40p: Add an 8514/A graphics card List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: =?ISO-8859-1?Q?Herv=E9_Poussineau?= , qemu-devel Developers , "Michael S. Tsirkin" 2011/6/16 Andreas F=E4rber : > Am 15.06.2011 um 06:33 schrieb Roy Tam: > >> 2011/6/14 Andreas F=E4rber : >>> >>> The IBM E15 is equivalent to an S3 Vision864. >>> >>> Lacking S3 SDAC (86C716) support, the DAC indizes are translated >>> to greyscale colors. This works sufficiently to observe firmware >>> boot progress. >>> >> >> IMO we can generalize it as a generic S3 Vision864 and use it in x86 gue= st >> too. > > What in particular would we need to generalize? It's qdev'ified; I don't > remember seeing anything PReP-specific in there. > It still needs VMState of course. > >> http://wiki.qemu.org/Google_Summer_of_Code_2011#Add_a_S3_Trio_or_S3_Virg= e >> CC: Natalia Portillo >> >>> Cc: Herv=E9 Poussineau >>> >>> Fixed off-by-one drawing issue. >>> Replaced hardcoded color for RECT. >>> Separate I/O debug output for readability. >>> >>> Signed-off-by: Andreas F=E4rber >>> --- >>> =A0Makefile.objs =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A01 + >>> =A0default-configs/ppc-softmmu.mak | =A0 =A01 + >>> =A0hw/pci_ids.h =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A03 + >>> =A0hw/ppc_prep.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A02 + >>> =A0hw/vga-s3.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0694 >>> +++++++++++++++++++++++++++++++++++++++ >>> =A05 files changed, 701 insertions(+), 0 deletions(-) >>> =A0create mode 100644 hw/vga-s3.c >>> >> [snip] >> >> IMO using vga-s3-864.c as the file name may be better as S3 produced >> many display chips. > > Actually in the meantime I've already renamed the file to vga-ibm8514a.c > (better: vga-ibm8514.c) and renamed the registration functions to reflect > the s3_vision864. > Actually what I mean is that, you may make the code to be more S3 Vision864-ish because S3 Vision864 extends its display capability, not only 1024*768 4/8bpp. > I agree that rather than bundling different graphics cards by one vendor = we > should bundle different implementations of the same chipset. I was assumi= ng > that the IBM E15 uses a different vendor_id at least but could share the > initialization with other cards, once mst's declarative PCI initializatio= n > reaches master (prepared that locally). > Supposedly the Miro 20SD is compatible with the S3 Vision864, and the ATI > Mach8 was based on IBM 8514/A, too. Not sure about the Weitek P9100-based > IBM S15. > > Any suggestions what to do about the RAMDAC would be appreciated. The > firmware only accesses the DAC_MASK register but does not write to the DA= C > itself, so for colors the card needs a reset handler that initializes the > 256-color palette to the right RGB values. > > Andreas