From: Peter Maydell <peter.maydell@linaro.org>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: Alexandre Raymond <cerbere@gmail.com>,
Alexander Graf <alex@csgraf.de>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH V2 2/3] Cocoa: avoid displaying window when command-line contains '-h' or '-help'
Date: Thu, 2 Jun 2011 07:10:52 +0100 [thread overview]
Message-ID: <BANLkTikErXbyPUf00OzPf97A2zZLap2zEQ@mail.gmail.com> (raw)
In-Reply-To: <375F5CD2-90DC-4E42-BB03-803AF1346AA6@web.de>
On 2 June 2011 00:05, Andreas Färber <andreas.faerber@web.de> wrote:
> Am 30.05.2011 um 00:32 schrieb Peter Maydell:
>> (1) presumably this doesn't work if you disable the display
>> with "-display none" ?
>
> I don't see how that would not work. It's just not handled specially here,
> so it will likely display a window - the former behavior of all these
> switches.
Yes, that's my point -- this chunk of code is trying to implement
"don't bring up the display window if we won't use it", and it
doesn't work properly [ie does not suppress the window in all the
cases where it should] because inevitably it lags behind the
set of options in vl.c which don't bring up the display window.
I don't particularly object to the patch being committed as a short
term measure.
-- PMM
next prev parent reply other threads:[~2011-06-02 6:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-29 22:22 [Qemu-devel] [PATCH V2 0/3] Fix compilation issues under darwin Alexandre Raymond
2011-05-29 22:22 ` [Qemu-devel] [PATCH V2 1/3] Darwin: Fix incorrect check for fdatasync() in configure Alexandre Raymond
2011-05-29 23:36 ` Andreas Färber
2011-05-30 0:09 ` Alexandre Raymond
2011-05-30 2:32 ` Alexandre Raymond
2011-06-01 22:26 ` Andreas Färber
2011-05-29 22:22 ` [Qemu-devel] [PATCH V2 2/3] Cocoa: avoid displaying window when command-line contains '-h' or '-help' Alexandre Raymond
2011-05-29 22:32 ` Peter Maydell
2011-05-29 22:40 ` Alexandre Raymond
2011-06-01 23:05 ` Andreas Färber
2011-06-02 6:10 ` Peter Maydell [this message]
2011-06-01 22:16 ` Andreas Färber
2011-05-29 22:22 ` [Qemu-devel] [PATCH V2 3/3] Remove warning in printf due to type mismatch Alexandre Raymond
2011-06-01 21:13 ` Andreas Färber
2011-06-02 7:18 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikErXbyPUf00OzPf97A2zZLap2zEQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alex@csgraf.de \
--cc=aliguori@us.ibm.com \
--cc=andreas.faerber@web.de \
--cc=cerbere@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).