From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44094)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QS17Q-0005VS-6b
	for qemu-devel@nongnu.org; Thu, 02 Jun 2011 02:10:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QS17O-0007xr-Nu
	for qemu-devel@nongnu.org; Thu, 02 Jun 2011 02:10:55 -0400
Received: from mail-px0-f174.google.com ([209.85.212.174]:62935)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QS17O-0007xj-Dx
	for qemu-devel@nongnu.org; Thu, 02 Jun 2011 02:10:54 -0400
Received: by pxi15 with SMTP id 15so373294pxi.33
	for <qemu-devel@nongnu.org>; Wed, 01 Jun 2011 23:10:52 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <375F5CD2-90DC-4E42-BB03-803AF1346AA6@web.de>
References: <1306707770-14632-1-git-send-email-cerbere@gmail.com>
	<1306707770-14632-3-git-send-email-cerbere@gmail.com>
	<BANLkTi=jFFTObX0RWO6irm4PMXAxBDCrgg@mail.gmail.com>
	<375F5CD2-90DC-4E42-BB03-803AF1346AA6@web.de>
Date: Thu, 2 Jun 2011 07:10:52 +0100
Message-ID: <BANLkTikErXbyPUf00OzPf97A2zZLap2zEQ@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V2 2/3] Cocoa: avoid displaying window when
 command-line contains '-h' or '-help'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <andreas.faerber@web.de>
Cc: Alexandre Raymond <cerbere@gmail.com>, Alexander Graf <alex@csgraf.de>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel Developers <qemu-devel@nongnu.org>

On 2 June 2011 00:05, Andreas F=C3=A4rber <andreas.faerber@web.de> wrote:
> Am 30.05.2011 um 00:32 schrieb Peter Maydell:
>> (1) presumably this doesn't work if you disable the display
>> with "-display none" ?
>
> I don't see how that would not work. It's just not handled specially here=
,
> so it will likely display a window - the former behavior of all these
> switches.

Yes, that's my point -- this chunk of code is trying to implement
"don't bring up the display window if we won't use it", and it
doesn't work properly [ie does not suppress the window in all the
cases where it should] because inevitably it lags behind the
set of options in vl.c which don't bring up the display window.

I don't particularly object to the patch being committed as a short
term measure.

-- PMM