From: andrzej zaborowski <balrogg@gmail.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Marcus Comstedt <marcus@mc.pp.se>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] bitbang_i2c: Fix spurious slave read after NACK
Date: Sun, 29 May 2011 03:49:57 +0200 [thread overview]
Message-ID: <BANLkTikEz_JrJ38iONRf0f_bqGXHVaSLDw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTinbdHYTdPgmZHwUBOb4xEmA=mjHnQ@mail.gmail.com>
Hi,
On 28 May 2011 21:52, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Sat, May 28, 2011 at 3:55 PM, Marcus Comstedt <marcus@mc.pp.se> wrote:
>> After NACKing a read operation, a raising SCL should not trigger a new
>> read from the slave. Introduce a new state which just waits for a stop
>> or start condition after NACK.
Makes sense, I pushed this change to master.
Cheers
prev parent reply other threads:[~2011-05-29 1:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 14:55 [Qemu-devel] [PATCH] bitbang_i2c: Fix spurious slave read after NACK Marcus Comstedt
2011-05-28 19:52 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2011-05-29 1:49 ` andrzej zaborowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikEz_JrJ38iONRf0f_bqGXHVaSLDw@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=marcus@mc.pp.se \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).