From: Peter Maydell <peter.maydell@linaro.org>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 11/14] linux-user: fpu_save_addr is not used
Date: Thu, 2 Jun 2011 14:51:21 +0100 [thread overview]
Message-ID: <BANLkTikFcL50hz4PMrm-2o4bPwzFkWOF9g@mail.gmail.com> (raw)
In-Reply-To: <60dd6cb1f888183df83a2d6b6b98e17c5991a093.1307014902.git.quintela@redhat.com>
On 2 June 2011 12:53, Juan Quintela <quintela@redhat.com> wrote:
> It is only read to set the error code?
> err |= __get_user(fpu_save_addr, &sf->fpu_save);
> -
> + (void)fpu_save_addr;
In linux-user __get_user can never generate an error: faults
are always caught by the lock_user_struct() or equivalent call
done beforehand. The error handling is I think a leftover from
code borrowed from the kernel (which does have a __get_user
that might return an error).
So I think the correct fix here is just to remove the __get_user
lines and the variables if they're not used.
-- PMM
next prev parent reply other threads:[~2011-06-02 13:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 11:53 [Qemu-devel] [PATCH 00/14] More gcc 4.6 warnings fixes Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 01/14] kvm: remove fop write only variable Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 02/14] tcg: define and set call_type only when it is used Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 03/14] flatload: memp was a write-only variable Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 04/14] xen: pentry is not used in this function Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 05/14] linuxload: id_change was a write only variable Juan Quintela
2011-06-10 17:04 ` Peter Maydell
2011-06-02 11:53 ` [Qemu-devel] [PATCH 06/14] flatload: end_code was only used in a debug message Juan Quintela
2011-06-10 15:31 ` Peter Maydell
2011-06-02 11:53 ` [Qemu-devel] [PATCH 07/14] alpha: fn2 was a write only variable Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 08/14] syscall: really return ret code Juan Quintela
2011-06-10 17:00 ` Peter Maydell
2011-06-02 11:53 ` [Qemu-devel] [PATCH 09/14] exec: last_first_tb was only used in !ONLY_USER case Juan Quintela
2011-06-17 11:38 ` Peter Maydell
2011-06-24 14:42 ` Stefan Hajnoczi
2011-06-02 11:53 ` [Qemu-devel] [PATCH 10/14] mips: we really need the extra arguments Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 11/14] linux-user: fpu_save_addr is not used Juan Quintela
2011-06-02 13:51 ` Peter Maydell [this message]
2011-06-02 14:59 ` Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 12/14] linux-user: syscall should use sanitized arg1 Juan Quintela
2011-06-10 17:13 ` Peter Maydell
2011-06-02 11:53 ` [Qemu-devel] [PATCH 13/14] alpha: disp12 is not used for USER emulation Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 14/14] lsi53c895a: current_dev is not used Juan Quintela
2011-06-02 12:24 ` Andreas Färber
2011-06-02 12:39 ` Juan Quintela
2011-06-02 13:05 ` [Qemu-devel] [PATCH 00/14] More gcc 4.6 warnings fixes Christophe Fergeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikFcL50hz4PMrm-2o4bPwzFkWOF9g@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).