From: Peter Maydell <peter.maydell@linaro.org>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Paul Brook <paul@codesourcery.com>,
qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 0/6] target-arm: reduce usage of global env
Date: Thu, 26 May 2011 20:34:35 +0100 [thread overview]
Message-ID: <BANLkTikKHwcp+WgmJmBLX-SN42sSLkudtA@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=i-SBYK88xv00L5RLi1EdWxtiRrQ@mail.gmail.com>
On 26 May 2011 20:01, Blue Swirl <blauwirbel@gmail.com> wrote:
> On Wed, May 25, 2011 at 7:00 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> This obviously still leaves some global CPUState use in op_helper.c,
>> but it's a move in the right direction.
>
> Have you seen any measurable changes in performance? The discussion
> about the performance effect of changes like this was not very
> conclusive.
Nope, I haven't measured. I was persuaded of the advantages
of dropping global CPUState purely for (a) consistency and
(b) avoiding nasty hacks.
-- PMM
next prev parent reply other threads:[~2011-05-26 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 16:00 [Qemu-devel] [PATCH 0/6] target-arm: reduce usage of global env Peter Maydell
2011-05-25 16:00 ` [Qemu-devel] [PATCH 1/6] Revert "target-arm: Use global env in iwmmxt_helper.c helpers" Peter Maydell
2011-05-25 16:00 ` [Qemu-devel] [PATCH 2/6] target-arm: Add helper function to generate code to get fpstatus pointer Peter Maydell
2011-05-25 16:00 ` [Qemu-devel] [PATCH 3/6] target-arm: Make VFP binop helpers take pointer to fpstatus, not CPUState Peter Maydell
2011-05-25 16:00 ` [Qemu-devel] [PATCH 4/6] target-arm: Pass fp status pointer explicitly to neon fp helpers Peter Maydell
2011-05-25 16:00 ` [Qemu-devel] [PATCH 5/6] Revert "target-arm: Use global env in neon_helper.c helpers" Peter Maydell
2011-05-25 16:00 ` [Qemu-devel] [PATCH 6/6] Revert "Makefile.target: Allow target helpers to be in any *_helper.c file" Peter Maydell
2011-05-26 19:01 ` [Qemu-devel] [PATCH 0/6] target-arm: reduce usage of global env Blue Swirl
2011-05-26 19:34 ` Peter Maydell [this message]
2011-05-26 19:46 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikKHwcp+WgmJmBLX-SN42sSLkudtA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=patches@linaro.org \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).