From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPgKM-0006vr-NW for qemu-devel@nongnu.org; Thu, 26 May 2011 15:34:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QPgKL-0006Qk-T2 for qemu-devel@nongnu.org; Thu, 26 May 2011 15:34:38 -0400 Received: from mail-px0-f173.google.com ([209.85.212.173]:58341) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPgKL-0006Ku-Ms for qemu-devel@nongnu.org; Thu, 26 May 2011 15:34:37 -0400 Received: by pxi16 with SMTP id 16so627675pxi.4 for ; Thu, 26 May 2011 12:34:35 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1306339215-1228-1-git-send-email-peter.maydell@linaro.org> Date: Thu, 26 May 2011 20:34:35 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 0/6] target-arm: reduce usage of global env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Paul Brook , qemu-devel@nongnu.org, Aurelien Jarno , patches@linaro.org On 26 May 2011 20:01, Blue Swirl wrote: > On Wed, May 25, 2011 at 7:00 PM, Peter Maydell wrote: >> This obviously still leaves some global CPUState use in op_helper.c, >> but it's a move in the right direction. > > Have you seen any measurable changes in performance? The discussion > about the performance effect of changes like this was not very > conclusive. Nope, I haven't measured. I was persuaded of the advantages of dropping global CPUState purely for (a) consistency and (b) avoiding nasty hacks. -- PMM