From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbY8q-0007qI-6g for qemu-devel@nongnu.org; Tue, 28 Jun 2011 09:15:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbY8n-0008S8-RL for qemu-devel@nongnu.org; Tue, 28 Jun 2011 09:15:48 -0400 Received: from mail-gx0-f173.google.com ([209.85.161.173]:35659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbY8n-0008Rs-DP for qemu-devel@nongnu.org; Tue, 28 Jun 2011 09:15:45 -0400 Received: by gxk26 with SMTP id 26so75707gxk.4 for ; Tue, 28 Jun 2011 06:15:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4E099A15.4050004@adacore.com> References: <1309178511-20027-1-git-send-email-chouteau@adacore.com> <4E08925F.3030605@adacore.com> <4E08ABF4.1010206@adacore.com> <4E099A15.4050004@adacore.com> Date: Tue, 28 Jun 2011 14:15:44 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimuma List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabien Chouteau Cc: qemu-devel@nongnu.org On Tue, Jun 28, 2011 at 10:08 AM, Fabien Chouteau wr= ote: > On 28/06/2011 10:34, Stefan Hajnoczi wrote: >> This patch doesn't hurt but we'd be just as well off without it. >> >> Did you do this to fix a bug? =A0If so, then something else in QEMU >> needs to be fixed, not slirp. > > When Qemu generates bad Ethernet frames, I think it's a bug. > > And again, this is the extension of a previous patch. If this patch is no= t > valid then we should revert the first, it's also a question of consistenc= y. IMO the previous patch is not necessary either. Since there is no net subsystem maintainer who can help decide which way to go, I'm going to back off from this issue. Please go ahead. Stefan