qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Alex Zuepke <azuepke@sysgo.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] ARM: BKPT instructions should raise prefetch aborts with IFSR type 00010
Date: Wed, 18 May 2011 18:44:33 +0100	[thread overview]
Message-ID: <BANLkTikM9QWERwqOf-QjMWz83CTNcOoP7Q@mail.gmail.com> (raw)
In-Reply-To: <4DD398CE.9040603@sysgo.com>

On 18 May 2011 11:00, Alex Zuepke <azuepke@sysgo.com> wrote:
> Peter Maydell schrieb:
>> On 25 March 2011 10:54, Alex Zuepke <azuepke@sysgo.com> wrote:
>>> while digging through some problems with BKPT exceptions on ARM, I
>>> discovered that QEMU does not update IFSR on prefetch aborts. This
>>> should be done since ARMv6 according to ARM docs. Please include.

> I tried to fix it, new patch attached.

Thanks. I've looked at it and given it a quick test; I'm
happy with this version.

> But I'm not sure if it is required for semihosting as well.

I think the value of IFSR is not defined after a semihosting
request (different implementations might use an actual SVC handler
or might intercept the SVC before it becomes an actual CPU SVC
exception). For QEMU we handle the semihosting request and
return immediately rather than actually delivering a CPU exception,
so I think it makes sense not to set IFSR in that case.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM

  reply	other threads:[~2011-05-18 17:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-25 10:54 [Qemu-devel] ARM: BKPT instructions should raise prefetch aborts with IFSR type 00010 Alex Zuepke
2011-03-25 11:39 ` Peter Maydell
2011-03-25 14:01   ` Alex Zuepke
2011-05-18 10:00   ` Alex Zuepke
2011-05-18 17:44     ` Peter Maydell [this message]
2011-06-03 16:42     ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTikM9QWERwqOf-QjMWz83CTNcOoP7Q@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=azuepke@sysgo.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).