From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56137 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q6PIe-00083i-3T
	for qemu-devel@nongnu.org; Sun, 03 Apr 2011 11:33:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Q6PIL-00036a-M1
	for qemu-devel@nongnu.org; Sun, 03 Apr 2011 11:32:59 -0400
Received: from mail-vw0-f45.google.com ([209.85.212.45]:49987)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Q6PIL-00036W-Fr
	for qemu-devel@nongnu.org; Sun, 03 Apr 2011 11:32:53 -0400
Received: by vws17 with SMTP id 17so4223072vws.4
	for <qemu-devel@nongnu.org>; Sun, 03 Apr 2011 08:32:53 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20110403151214.GK31037@volta.aurel32.net>
References: <1301668243-29886-1-git-send-email-peter.maydell@linaro.org>
	<1301668243-29886-2-git-send-email-peter.maydell@linaro.org>
	<AANLkTinLgJDOaaMQft_gMpGjOgmZ33ojB+GV6kfPh9pY@mail.gmail.com>
	<AANLkTimMiHupSuDJdfOtpfrn9Ou_hRH=FtemGC+Y+DpK@mail.gmail.com>
	<BANLkTi=Arv9QE5t0jXW3WjCrjmvkjaG1mg@mail.gmail.com>
	<BANLkTin4o2NXVty8MsmYpmw3VVom4BrC+Q@mail.gmail.com>
	<BANLkTi=89=Lsq0NjuJkgqgHhD_eKuK123g@mail.gmail.com>
	<BANLkTimzh5VwSH_wemreFWL2o0A5QK+Zfg@mail.gmail.com>
	<20110403151214.GK31037@volta.aurel32.net>
Date: Sun, 3 Apr 2011 16:32:51 +0100
Message-ID: <BANLkTikMp+w_vHe1Q47tdtWcmwQ5vryMDg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines
	use correct FP status
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On 3 April 2011 16:12, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On Sun, Apr 03, 2011 at 12:21:49PM +0100, Peter Maydell wrote:
>> Anyway, how about I do a version of this patch which moves
>> the affected neon helpers to op_helper.c rather than adding
>> an env parameter

>> Then I can do a separate patchset to move other helpers,
>> rather than tangling a code-cleanup patchset with Neon
>> correctness fixes.

> This solution looks fine for me. That said, I am not sure moving
> everything to op_helper.c is the best solution. I would rather go for
> compiling *_helper.c with HELPER_CFLAGS, which avoids having one big
> file which is messy to edit, and long to compile.

That sounds better, actually, and avoids moving too much
code around. Still leaves the choice of:
 * move VFP helpers from target-arm/helper.c to another file
 * compile all target-*/helper.c with HELPER_CFLAGS
 * arm-specific exception in Makefile.target

of which I'll go for option 1.

-- PMM