Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

[Stefan Hajnoczi <stefanha@gmail.com>]

On Fri, Jun 24, 2011 at 2:31 PM, Marc-Antoine Perennou
<Marc-Antoine@perennou.com> wrote:
> On 10 June 2011 09:14, Markus Armbruster <armbru@redhat.com> wrote:
>> Peter Maydell <peter.maydell@linaro.org> writes:
>>
>>> On 9 June 2011 18:44, Andreas Färber <andreas.faerber@web.de> wrote:
>>>> Am 09.06.2011 um 17:52 schrieb Marc-Antoine Perennou:
>>>>> Manually including stddef.h or replacing NULL by 0 or (void*)0 makes it
>>>>> work.
>>>>
>>>> Then please submit a new patch that explicit includes that header with a
>>>> comment explaining why, so that it doesn't get removed by accident.
>>>
>>> I think the original patch is fine. This configure test isn't
>>> trying to test whether we correctly found some definition of
>>> NULL, it's testing pulseaudio presence. The test code should
>>> be the simplest and most stand-alone code that achieves that.
>>> There's no need to go dragging in extra headers when we don't
>>> even need to be using NULL here anyhow.
>>>
>>> We already have configure tests which use unadorned 0 for
>>> pointers (eg the pthread test), it's legal C, and it works.
>>> I think we should call this a trivial patch and just apply it.
>>>
>>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>>
>> I agree with your reasoning.
>>
>
> If you want me to provide a patch with the extra include instead, I
> can, otherwise, could this trivial one get merged so qemu-kvm can be
> built on several systems on which it actually can't ?

It is in the trivial-patches tree now.  qemu.git will pick it up next
and then qemu-kvm.git will pull it in when it syncs up with qemu.git.

Stefan