From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa9c2-0002kY-TT for qemu-devel@nongnu.org; Fri, 24 Jun 2011 12:52:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qa9c0-0000hL-Aq for qemu-devel@nongnu.org; Fri, 24 Jun 2011 12:52:10 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:47497) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa9bz-0000h9-VF for qemu-devel@nongnu.org; Fri, 24 Jun 2011 12:52:08 -0400 Received: by gyg10 with SMTP id 10so1507680gyg.4 for ; Fri, 24 Jun 2011 09:52:07 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20110603203309.GB14583@volta.aurel32.net> <20110603221707.GI14583@volta.aurel32.net> <5C8D49DE-B25A-4B4D-9170-E81BEBCB8D2E@web.de> Date: Fri, 24 Jun 2011 17:52:06 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marc-Antoine Perennou Cc: Peter Maydell , =?ISO-8859-1?Q?Andreas_F=E4rber?= , Markus Armbruster , Aurelien Jarno , qemu-devel@nongnu.org On Fri, Jun 24, 2011 at 2:31 PM, Marc-Antoine Perennou wrote: > On 10 June 2011 09:14, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 9 June 2011 18:44, Andreas F=E4rber wrote: >>>> Am 09.06.2011 um 17:52 schrieb Marc-Antoine Perennou: >>>>> Manually including stddef.h or replacing NULL by 0 or (void*)0 makes = it >>>>> work. >>>> >>>> Then please submit a new patch that explicit includes that header with= a >>>> comment explaining why, so that it doesn't get removed by accident. >>> >>> I think the original patch is fine. This configure test isn't >>> trying to test whether we correctly found some definition of >>> NULL, it's testing pulseaudio presence. The test code should >>> be the simplest and most stand-alone code that achieves that. >>> There's no need to go dragging in extra headers when we don't >>> even need to be using NULL here anyhow. >>> >>> We already have configure tests which use unadorned 0 for >>> pointers (eg the pthread test), it's legal C, and it works. >>> I think we should call this a trivial patch and just apply it. >>> >>> Reviewed-by: Peter Maydell >> >> I agree with your reasoning. >> > > If you want me to provide a patch with the extra include instead, I > can, otherwise, could this trivial one get merged so qemu-kvm can be > built on several systems on which it actually can't ? It is in the trivial-patches tree now. qemu.git will pick it up next and then qemu-kvm.git will pull it in when it syncs up with qemu.git. Stefan