From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QDdsM-0002L8-Tw for qemu-devel@nongnu.org; Sat, 23 Apr 2011 10:31:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QDdsL-00043P-To for qemu-devel@nongnu.org; Sat, 23 Apr 2011 10:31:58 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:43128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QDdsL-00043K-Qy for qemu-devel@nongnu.org; Sat, 23 Apr 2011 10:31:57 -0400 Received: by gwb19 with SMTP id 19so413434gwb.4 for ; Sat, 23 Apr 2011 07:31:57 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20110406183503.22854.39534.stgit@ginnungagap.bsc.es> References: <20110406183341.22854.93929.stgit@ginnungagap.bsc.es> <20110406183503.22854.39534.stgit@ginnungagap.bsc.es> Date: Sat, 23 Apr 2011 15:31:56 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Llu=EDs?= Cc: qemu-devel@nongnu.org, chouteau@adacore.com On Wed, Apr 6, 2011 at 7:35 PM, Llu=EDs wrote: > This includes all the control interfaces already provided by the "simple" > backend (i.e., command line, programmatic and monitor). > > Signed-off-by: Fabien Chouteau > Signed-off-by: Llu=EDs Vilanova > --- > =A0Makefile.objs =A0 =A0 | =A0 =A08 +++++++- > =A0configure =A0 =A0 =A0 =A0 | =A0 =A03 +++ > =A0docs/tracing.txt =A0| =A0 =A06 ++---- > =A0hmp-commands.hx =A0 | =A0 10 ++++++++-- > =A0monitor.c =A0 =A0 =A0 =A0 | =A0 =A08 +++++++- > =A0qemu-config.c =A0 =A0 | =A0 =A07 ++++--- > =A0qemu-options.hx =A0 | =A0 =A08 +++++++- > =A0scripts/tracetool | =A0 33 ++++++++++++++++++++++++++++----- > =A0stderrtrace.c =A0 =A0 | =A0 24 ++++++++++++++++++++++++ > =A0stderrtrace.h =A0 =A0 | =A0 14 ++++++++++++++ > =A0vl.c =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 11 +++++++++-- > =A011 files changed, 113 insertions(+), 19 deletions(-) > =A0create mode 100644 stderrtrace.c > =A0create mode 100644 stderrtrace.h I feel that the monitor commands for the simple backend were a mistake. Simple trace is used during development, not production, so being able to toggle trace events at runtime is probably not worth the extra user interfaces we've added. But when the simple backend was written we thought it would be used in production and planned for libvirt interfaces and all ;). Let's not go down that road for the stderr backend which is very useful today at a tiny cost in code size. For tracing use cases that require performance or runtime enabling/disabling trace events, just use the simple, ust, or dtrace backends. Please drop this patch. Stefan