From: Peter Maydell <peter.maydell@linaro.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm@vger.kernel.org, "Marcelo Tosatti" <mtosatti@redhat.com>,
"Alexander Graf" <agraf@suse.de>,
qemu-devel@nongnu.org, "Andreas Färber" <andreas.faerber@web.de>,
"Avi Kivity" <avi@redhat.com>, "Christoph Hellwig" <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 01/12] Add kernel header update script
Date: Wed, 8 Jun 2011 15:33:58 +0100 [thread overview]
Message-ID: <BANLkTikUc8Dr8hYMgUqbLjbwBPWrbVvEyQ@mail.gmail.com> (raw)
In-Reply-To: <b7e14da2dbade9affee696a5997db1df5019ce43.1307542247.git.jan.kiszka@siemens.com>
On 8 June 2011 15:10, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> --- /dev/null
> +++ b/scripts/update-linux-headers.sh
> @@ -0,0 +1,55 @@
> +#!/bin/sh -e
> +#
> +if [ -z "$output" ]; then
> + output=$PWD
> +fi
> + mkdir -p $output/linux-headers/asm-$arch
This script is rather lacking in quoting throughout. As a random
example, this looks like it will break if you run the script from
a directory with a space in the path.
> +tmpdir=$TMPDIR/.tmp-hdrs-$$
Better (safer) to use mktemp, I think.
> if [ -z "$linux" -o ! -d "$linux" ]; then
test -o is obsolescent in POSIX; use
if [ -z "$linux" ] || ! [ -d "$linux" ] ; then
instead.
-- PMM
next prev parent reply other threads:[~2011-06-08 14:34 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 14:10 [Qemu-devel] [PATCH 00/12] [uq/master] Import linux headers and some cleanups Jan Kiszka
2011-06-08 14:10 ` [Qemu-devel] [PATCH 01/12] Add kernel header update script Jan Kiszka
2011-06-08 14:33 ` Peter Maydell [this message]
2011-06-08 14:39 ` Jan Kiszka
2011-06-08 14:51 ` Peter Maydell
2011-06-08 15:06 ` [Qemu-devel] [PATCH v2 " Jan Kiszka
2011-06-08 15:57 ` Peter Maydell
2011-06-08 16:22 ` [Qemu-devel] [PATCH v3 " Jan Kiszka
2011-06-08 17:30 ` Peter Maydell
2011-06-08 14:10 ` [Qemu-devel] [PATCH 02/12] Import kernel headers Jan Kiszka
2011-06-08 14:10 ` [Qemu-devel] [PATCH 03/12] Switch build system to accompanied " Jan Kiszka
2011-06-14 11:11 ` Alexander Graf
2011-06-14 11:21 ` Jan Kiszka
2011-06-14 11:28 ` Alexander Graf
2011-06-14 11:32 ` Jan Kiszka
2011-06-22 20:51 ` Stefan Weil
2011-06-22 21:37 ` Jan Kiszka
2011-06-23 5:37 ` Stefan Weil
2011-06-23 7:18 ` Jan Kiszka
2011-06-23 8:05 ` [Qemu-devel] [PATCH] Fix fallouts from Linux header inclusion Jan Kiszka
2011-06-23 10:59 ` Andreas Färber
2011-06-23 15:14 ` Stefan Weil
2011-06-26 18:01 ` Blue Swirl
2011-06-08 14:10 ` [Qemu-devel] [PATCH 04/12] kvm: Drop CONFIG_KVM_PARA Jan Kiszka
2011-06-08 14:10 ` [Qemu-devel] [PATCH 05/12] kvm: ppc: Drop CONFIG_KVM_PPC_PVR Jan Kiszka
2011-06-14 11:06 ` Alexander Graf
2011-06-08 14:11 ` [Qemu-devel] [PATCH 06/12] kvm: Drop useless zero-initializations Jan Kiszka
2011-06-08 14:11 ` [Qemu-devel] [PATCH 07/12] kvm: Drop KVM_CAP build dependencies Jan Kiszka
2011-06-14 11:05 ` Alexander Graf
2011-06-14 11:07 ` Jan Kiszka
2011-06-14 11:17 ` Alexander Graf
2011-06-14 11:19 ` Jan Kiszka
2011-06-14 11:25 ` Alexander Graf
2011-06-08 14:11 ` [Qemu-devel] [PATCH 08/12] kvm: x86: " Jan Kiszka
2011-06-08 14:11 ` [Qemu-devel] [PATCH 09/12] kvm: ppc: " Jan Kiszka
2011-06-10 18:32 ` Eduardo Habkost
2011-06-11 7:45 ` Jan Kiszka
2011-06-14 11:07 ` Alexander Graf
2011-06-08 14:11 ` [Qemu-devel] [PATCH 10/12] kvm: Clean up stubs Jan Kiszka
2011-06-08 14:11 ` [Qemu-devel] [PATCH 11/12] kvm: x86: Pass KVMState to kvm_arch_get_supported_cpuid Jan Kiszka
2011-06-09 17:33 ` Eduardo Habkost
2011-06-09 17:41 ` Jan Kiszka
2011-06-09 18:08 ` Eduardo Habkost
2011-06-09 19:53 ` Jan Kiszka
2011-06-08 14:11 ` [Qemu-devel] [PATCH 12/12] Remove unneeded kvm.h from cpu-exec.c Jan Kiszka
2011-06-20 18:24 ` [Qemu-devel] [PATCH 00/12] [uq/master] Import linux headers and some cleanups Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikUc8Dr8hYMgUqbLjbwBPWrbVvEyQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=agraf@suse.de \
--cc=andreas.faerber@web.de \
--cc=avi@redhat.com \
--cc=hch@lst.de \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).