From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44770)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QUJpa-0001fd-PQ
	for qemu-devel@nongnu.org; Wed, 08 Jun 2011 10:34:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QUJpX-0000hm-Qr
	for qemu-devel@nongnu.org; Wed, 08 Jun 2011 10:34:02 -0400
Received: from mail-px0-f174.google.com ([209.85.212.174]:62180)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QUJpX-0000hi-G4
	for qemu-devel@nongnu.org; Wed, 08 Jun 2011 10:33:59 -0400
Received: by pxi15 with SMTP id 15so432110pxi.33
	for <qemu-devel@nongnu.org>; Wed, 08 Jun 2011 07:33:58 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <b7e14da2dbade9affee696a5997db1df5019ce43.1307542247.git.jan.kiszka@siemens.com>
References: <cover.1307542247.git.jan.kiszka@siemens.com>
	<b7e14da2dbade9affee696a5997db1df5019ce43.1307542247.git.jan.kiszka@siemens.com>
Date: Wed, 8 Jun 2011 15:33:58 +0100
Message-ID: <BANLkTikUc8Dr8hYMgUqbLjbwBPWrbVvEyQ@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 01/12] Add kernel header update script
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, =?UTF-8?Q?Andreas_F=C3=A4rber?= <andreas.faerber@web.de>, Avi Kivity <avi@redhat.com>, Christoph Hellwig <hch@lst.de>

On 8 June 2011 15:10, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> --- /dev/null
> +++ b/scripts/update-linux-headers.sh
> @@ -0,0 +1,55 @@
> +#!/bin/sh -e
> +#

> +if [ -z "$output" ]; then
> + =C2=A0 =C2=A0output=3D$PWD
> +fi

> + =C2=A0 =C2=A0mkdir -p $output/linux-headers/asm-$arch

This script is rather lacking in quoting throughout. As a random
example, this looks like it will break if you run the script from
a directory with a space in the path.

> +tmpdir=3D$TMPDIR/.tmp-hdrs-$$

Better (safer) to use mktemp, I think.

> if [ -z "$linux" -o ! -d "$linux" ]; then

test -o is obsolescent in POSIX; use
 if [ -z "$linux" ] || ! [ -d "$linux" ] ; then
instead.

-- PMM