qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Raymond <cerbere@gmail.com>
To: Nathan Whitehorn <nwhitehorn@freebsd.org>
Cc: "Andreas Färber" <andreas.faerber@web.de>,
	"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Fix build on FreeBSD
Date: Tue, 7 Jun 2011 11:27:31 -0400	[thread overview]
Message-ID: <BANLkTikWGMGP39H3k+TWc8_K7-Y7TR2Vuw@mail.gmail.com> (raw)
In-Reply-To: <4DEB8CB3.8000400@freebsd.org>

Hi Nathan,

On Sun, Jun 5, 2011 at 10:03 AM, Nathan Whitehorn
<nwhitehorn@freebsd.org> wrote:
> On 06/02/11 10:01, Andreas Färber wrote:
>>
>> Am 31.05.2011 um 16:57 schrieb Nathan Whitehorn:
>>
>>> Add some includes required to build qemu on FreeBSD.
>>
>> Missing Sob.
>
> Oops, I'll resubmit.
>
>>> ---
>>> bsd-user/syscall.c |    2 ++
>>> iohandler.c        |    1 +
>>> os-posix.c         |    4 ++++
>>> 3 files changed, 7 insertions(+), 0 deletions(-)
>>
>> [...]
>>>
>>> diff --git a/iohandler.c b/iohandler.c
>>> index 2b82421..7266aca 100644
>>> --- a/iohandler.c
>>> +++ b/iohandler.c
>>> @@ -29,6 +29,7 @@
>>>
>>> #ifndef _WIN32
>>> #include <sys/wait.h>
>>> +#include <signal.h>
>>> #endif
>>>
>>> typedef struct IOHandlerRecord {
>>
>> This is independent of the other BSD issues (that I cannot judge) and
>> affects Darwin and Haiku as well. Did you check that with your patch Win32
>> does not need the header?
>>
>> Alexandre (cc'ed) posted a slightly different patch, adding it in
>> qemu-common.h instead.
Normally, the following patch should solve this particular missing
header. It's already been added to the trivial patches queue by
Stefan.
http://patchwork.ozlabs.org/patch/98325/

Alexandre

  reply	other threads:[~2011-06-07 15:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-31 14:57 [Qemu-devel] [PATCH] Fix build on FreeBSD Nathan Whitehorn
2011-06-02 15:01 ` Andreas Färber
2011-06-05 14:03   ` Nathan Whitehorn
2011-06-07 15:27     ` Alexandre Raymond [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-03-03 16:34 Nathan Whitehorn
2012-03-17 16:20 ` Blue Swirl
2012-03-17 21:55   ` Nathan Whitehorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTikWGMGP39H3k+TWc8_K7-Y7TR2Vuw@mail.gmail.com \
    --to=cerbere@gmail.com \
    --cc=andreas.faerber@web.de \
    --cc=nwhitehorn@freebsd.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).